Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(487)

Issue 165800043: code review 165800043: doc/go1.4.html: vanity imports and internal packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by r
Modified:
10 years, 4 months ago
Reviewers:
rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

doc/go1.4.html: vanity imports and internal packages

Patch Set 1 #

Total comments: 7

Patch Set 2 : diff -r f828b26bf69bf53c232c2f84f94ae0106e01bd85 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -14 lines) Patch
M doc/go1.4.html View 1 7 chunks +93 lines, -14 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2014-10-28 17:29:39 UTC) #1
rsc
LGTM https://codereview.appspot.com/165800043/diff/1/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/165800043/diff/1/doc/go1.4.html#newcode199 doc/go1.4.html:199: is with the tree rooted at the parent ...
10 years, 4 months ago (2014-10-28 17:35:20 UTC) #2
r
https://codereview.appspot.com/165800043/diff/1/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/165800043/diff/1/doc/go1.4.html#newcode199 doc/go1.4.html:199: is with the tree rooted at the parent of ...
10 years, 4 months ago (2014-10-28 17:51:09 UTC) #3
r
10 years, 4 months ago (2014-10-28 17:51:33 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=4d78f41ca8c9 ***

doc/go1.4.html: vanity imports and internal packages

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/165800043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b