Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(232)

Issue 165750043: cloud/pubsub: Return a known error if pull timeout occurs

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by jbd
Modified:
9 years, 7 months ago
Reviewers:
adg, adg1, djd
CC:
veneer-firehose_google.com
Visibility:
Public.

Description

cloud/pubsub: Return a known error if pull timeout occurs.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M pubsub/integration_test.go View 2 chunks +6 lines, -0 lines 0 comments Download
M pubsub/pubsub.go View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4
jbd
9 years, 7 months ago (2014-10-28 04:43:25 UTC) #1
adg1
LGTM Weird they send 'bad request' on timeout :-/
9 years, 7 months ago (2014-10-28 04:49:28 UTC) #2
jbd
On 2014/10/28 04:49:28, adg1 wrote: > LGTM > > Weird they send 'bad request' on ...
9 years, 7 months ago (2014-10-28 04:51:16 UTC) #3
jbd
9 years, 7 months ago (2014-10-28 04:55:56 UTC) #4
Submitted as 098f2718b3def6d507e309e1097be4f200580e91.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b