Issue 165740043: code review 165740043: go.tools/dashboard/app: fix tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 165740043: code review 165740043: go.tools/dashboard/app: fix tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by adg

Modified:
10 years, 8 months ago

Reviewers:

CC:
bradfitz, dvyukov, golang-codereviews

Visibility:
Public.

Description

go.tools/dashboard/app: fix tests

Patch Set 1 #

Patch Set 2 : diff -r c542671bd34064e161693aa3cf5fb1d00ba85425 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r f8df5d1914f62e102b1a49876575197673d25862 https://code.google.com/p/go.tools #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
M	dashboard/app/build/build.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dashboard/app/build/handler.go	View	1 2	3 chunks	+4 lines, -2 lines	0 comments	Download
M	dashboard/app/build/test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adg

Hello bradfitz@golang.org, dvyukov, dvyukov@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 8 months ago (2014-10-30 22:03:42 UTC) #1

adg

10 years, 8 months ago (2014-10-30 22:03:56 UTC) #2

*** Submitted as
https://code.google.com/p/go/source/detail?r=bae572915db9&repo=tools ***

go.tools/dashboard/app: fix tests

TBR=dvyukov
R=dvyukov, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/165740043

Expand All Messages | Collapse All Messages