Issue 1657041: lit fixes for windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1657041: lit fixes for windows

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by Bigcheesegs

Modified:
4 years, 5 months ago

Reviewers:

Base URL:
http://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Description

This patch fixes several problems with lit that prevented tests from passing on windows. 1.) Change slashes in paths from '\' to '/' so the Tcl parser doesn't try to escape them. 2.) If a command cannot be located, try to run it with cmd.exe /c (this fixes macho-dump)

Patch Set 1 #

Total comments: 1

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+309 lines, -293 lines)			Patch
test/Scripts/macho-dump	View	1 chunk	+0 lines, -289 lines	0 comments	Download
test/Scripts/macho-dump.py	View	1 chunk	+289 lines, -0 lines	0 comments	Download
test/lit.cfg	View	1 chunk	+1 line, -0 lines	0 comments	Download
utils/lit/lit/TestRunner.py	View	3 chunks	+19 lines, -4 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Bigcheesegs

13 years, 10 months ago (2010-06-11 23:14:04 UTC) #2

http://codereview.appspot.com/1657041/diff/1/5
File utils/lit/lit/TestRunner.py (right):

http://codereview.appspot.com/1657041/diff/1/5#newcode155
utils/lit/lit/TestRunner.py:155: print args
Oops, this print shouldn't be here. I was using it for debugging.

Expand All Messages | Collapse All Messages