Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6768)

Issue 1657041: lit fixes for windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by Bigcheesegs
Modified:
4 weeks ago
Reviewers:
Base URL:
http://llvm.org/svn/llvm-project/llvm/trunk/
Visibility:
Public.

Description

This patch fixes several problems with lit that prevented tests from passing on windows. 1.) Change slashes in paths from '\' to '/' so the Tcl parser doesn't try to escape them. 2.) If a command cannot be located, try to run it with cmd.exe /c (this fixes macho-dump)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -293 lines) Patch
test/Scripts/macho-dump View 1 chunk +0 lines, -289 lines 0 comments Download
test/Scripts/macho-dump.py View 1 chunk +289 lines, -0 lines 0 comments Download
test/lit.cfg View 1 chunk +1 line, -0 lines 0 comments Download
utils/lit/lit/TestRunner.py View 3 chunks +19 lines, -4 lines 1 comment Download

Messages

Total messages: 2
Bigcheesegs
9 years, 6 months ago (2010-06-11 08:34:06 UTC) #1
Bigcheesegs
9 years, 6 months ago (2010-06-11 23:14:04 UTC) #2
http://codereview.appspot.com/1657041/diff/1/5
File utils/lit/lit/TestRunner.py (right):

http://codereview.appspot.com/1657041/diff/1/5#newcode155
utils/lit/lit/TestRunner.py:155: print args
Oops, this print shouldn't be here. I was using it for debugging.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b