Issue 1656042: Update to the latest selenium API and new Rakefile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1656042: Update to the latest selenium API and new Rakefile

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by razmyslovich

Modified:
13 years, 10 months ago

Reviewers:
sauta, baran, Eran, viarheichyk

CC:
webdriver-mobile-eng_google.com

Base URL:
http://webkitdriver.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -28 lines)			Patch
M	driver/Rakefile	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	driver/src/java/org/openqa/selenium/webkit/WebKitDriver.java	View	9 chunks	+18 lines, -22 lines	1 comment	Download
M	driver/src/java/org/openqa/selenium/webkit/WebKitWebElement.java	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	driver/test/java/org/openqa/selenium/webkit/WebKitDriverTestSuite.java	View	1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

sauta

LGTM. http://codereview.appspot.com/1656042/diff/1/4 File driver/src/java/org/openqa/selenium/webkit/WebKitDriver.java (right): http://codereview.appspot.com/1656042/diff/1/4#newcode214 driver/src/java/org/openqa/selenium/webkit/WebKitDriver.java:214: if (true || !WebKitJNI.isMainThread()) Remove 'true'.

13 years, 10 months ago (2010-06-11 14:23:18 UTC) #2

Eran

http://codereview.appspot.com/1656042/diff/1/5 File driver/src/java/org/openqa/selenium/webkit/WebKitWebElement.java (right): http://codereview.appspot.com/1656042/diff/1/5#newcode76 driver/src/java/org/openqa/selenium/webkit/WebKitWebElement.java:76: // HTML5MediaWebElement was removed from the last selenium No ...

13 years, 10 months ago (2010-06-11 15:02:32 UTC) #3

LGTM.

Expand All Messages | Collapse All Messages