Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1335)

Issue 165530043: engine: Disable key processing on password input (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by Daiki Ueno
Modified:
9 years, 5 months ago
Reviewers:
shawn.p.huang, Peng, maiku.fabian
Base URL:
git@github.com:ibus/ibus-m17n.git@master
Visibility:
Public.

Description

engine: Disable key processing on password input BUG=https://bugzilla.redhat.com/show_bug.cgi?id=1024071 Committed: 791efddb3a69eda18763f988e5d9df45e08e36a5

Patch Set 1 #

Total comments: 2

Patch Set 2 : remember purpuse/hints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M src/engine.c View 1 5 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Daiki Ueno
9 years, 6 months ago (2014-11-06 07:12:44 UTC) #1
maiku.fabian
I tested the above patch on top of current git master, i.e. on top of ...
9 years, 6 months ago (2014-11-06 09:11:19 UTC) #2
Peng
https://codereview.appspot.com/165530043/diff/1/src/engine.c File src/engine.c (right): https://codereview.appspot.com/165530043/diff/1/src/engine.c#newcode672 src/engine.c:672: if (!m17n->has_focus) Why not remember the content type, and ...
9 years, 6 months ago (2014-11-06 15:53:29 UTC) #3
Daiki Ueno
https://codereview.appspot.com/165530043/diff/1/src/engine.c File src/engine.c (right): https://codereview.appspot.com/165530043/diff/1/src/engine.c#newcode672 src/engine.c:672: if (!m17n->has_focus) On 2014/11/06 15:53:29, Peng wrote: > Why ...
9 years, 6 months ago (2014-11-07 03:59:55 UTC) #4
Peng
lgtm
9 years, 6 months ago (2014-11-07 16:05:44 UTC) #5
Daiki Ueno
9 years, 5 months ago (2014-11-13 03:09:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
791efddb3a69eda18763f988e5d9df45e08e36a5 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b