Issue 165510043: [dev.garbage] code review 165510043: cmd/gc: emit pointer write barriers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 165510043: [dev.garbage] code review 165510043: cmd/gc: emit pointer write barriers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by rsc

Modified:
10 years, 5 months ago

Reviewers:
gobot, rlh

CC:
rlh, golang-codereviews

Visibility:
Public.

cmd/gc: emit pointer write barriers This got lost in the change that added the writebarrierfat variants.

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/gc/walk.c	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 4

rsc

Hello rlh (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.garbage branch ...

10 years, 5 months ago (2014-11-05 20:35:44 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=9539a375b3fd *** [dev.garbage] cmd/gc: emit pointer write barriers This got lost in ...

10 years, 5 months ago (2014-11-05 20:43:46 UTC) #3

gobot

10 years, 5 months ago (2014-11-05 22:22:52 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/f6a1825081f9a62070d15a9e231bbfb9f9f3b8b1