Issue 16550046: Add option to generate simplestreams mirror info

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16550046: Add option to generate simplestreams mirror info (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by wallyworld

Modified:
10 years, 6 months ago

Reviewers:
mp+192590, thumper

Visibility:
Public.

Description

Add option to generate simplestreams mirror info When generating tools metadata using sync-tools or the tools plugin, add option is provided to optionally generate mirrors metadata. The option is --public because it is used when generating tools metadata for public clouds. https://code.launchpad.net/~wallyworld/juju-core/generate-mirrors-info/+merge/192590 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add option to generate simplestreams mirror info #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -50 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/synctools.go	View		4 chunks	+7 lines, -4 lines	0 comments	Download
M	cmd/juju/synctools_test.go	View		3 chunks	+9 lines, -1 line	0 comments	Download
M	cmd/jujud/agent_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/plugins/juju-metadata/toolsmetadata.go	View		5 chunks	+12 lines, -7 lines	2 comments	Download
M	cmd/plugins/juju-metadata/toolsmetadata_test.go	View		5 chunks	+30 lines, -7 lines	0 comments	Download
M	environs/simplestreams/simplestreams.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	environs/sync/sync.go	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	environs/sync/sync_test.go	View		6 chunks	+35 lines, -9 lines	0 comments	Download
M	environs/testing/tools.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/tools/simplestreams.go	View	1	4 chunks	+31 lines, -4 lines	0 comments	Download
M	environs/tools/simplestreams_test.go	View		5 chunks	+21 lines, -9 lines	0 comments	Download
M	environs/tools/testing/testing.go	View		3 chunks	+8 lines, -1 line	0 comments	Download
M	worker/upgrader/upgrader_test.go	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

thumper

LGTM with usual name bikeshedding https://codereview.appspot.com/16550046/diff/20001/cmd/plugins/juju-metadata/toolsmetadata.go File cmd/plugins/juju-metadata/toolsmetadata.go (right): https://codereview.appspot.com/16550046/diff/20001/cmd/plugins/juju-metadata/toolsmetadata.go#newcode80 cmd/plugins/juju-metadata/toolsmetadata.go:80: writeMirrors = tools.DoWriteMirrors I ...

10 years, 6 months ago (2013-10-30 02:19:33 UTC) #3

wallyworld

10 years, 6 months ago (2013-10-30 02:29:00 UTC) #4

https://codereview.appspot.com/16550046/diff/20001/cmd/plugins/juju-metadata/...
File cmd/plugins/juju-metadata/toolsmetadata.go (right):

https://codereview.appspot.com/16550046/diff/20001/cmd/plugins/juju-metadata/...
cmd/plugins/juju-metadata/toolsmetadata.go:80: writeMirrors =
tools.DoWriteMirrors
On 2013/10/30 02:19:33, thumper wrote:
> I think I'd prefer this to be "tools.WriteMirrors", I think the "Do" is
surplus
> to requirements.

Done.

Expand All Messages | Collapse All Messages