Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(831)

Issue 165110043: [dev.power64] code review 165110043: all: merge default (dd5014ed9b01) into dev.power64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rsc
Modified:
10 years, 8 months ago
Reviewers:
austin
CC:
austin, golang-codereviews
Visibility:
Public.

Description

all: merge default (dd5014ed9b01) into dev.power64 Still passes on amd64.

Patch Set 1 #

Patch Set 2 : diff -r 1eecc78cf304df88a5f6f8321a78f86954407271 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1eecc78cf304df88a5f6f8321a78f86954407271 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 1eecc78cf304df88a5f6f8321a78f86954407271 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1341 lines, -293 lines) Patch
M doc/asm.html View 1 7 chunks +111 lines, -20 lines 0 comments Download
M doc/go1.4.html View 1 1 chunk +598 lines, -0 lines 0 comments Download
R doc/go1.4.txt View 1 1 chunk +0 lines, -53 lines 0 comments Download
M doc/go_mem.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
M doc/go_spec.html View 1 5 chunks +4 lines, -11 lines 0 comments Download
M src/cmd/gc/builtin.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gc/runtime.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gc/walk.c View 1 11 chunks +127 lines, -126 lines 0 comments Download
M src/cmd/go/get.go View 1 5 chunks +12 lines, -2 lines 0 comments Download
M src/cmd/go/test.bash View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/cmd/objdump/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/objdump/objdump_test.go View 1 2 chunks +17 lines, -2 lines 0 comments Download
M src/encoding/json/encode.go View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/encoding/json/encode_test.go View 1 1 chunk +52 lines, -0 lines 0 comments Download
M src/fmt/doc.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/html/template/js_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/net/z_last_test.go View 1 2 chunks +62 lines, -0 lines 0 comments Download
M src/os/dir_unix.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/os/file.go View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/os/file_plan9.go View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/os/file_posix.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/os/file_unix.go View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/os/file_windows.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/asm_386.s View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/runtime/asm_amd64.s View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/runtime/asm_arm.s View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/runtime/crash_cgo_test.go View 1 3 chunks +52 lines, -0 lines 0 comments Download
M src/runtime/crash_test.go View 1 2 chunks +15 lines, -2 lines 0 comments Download
M src/runtime/debug/garbage.go View 1 2 chunks +21 lines, -9 lines 0 comments Download
M src/runtime/debug/garbage_test.go View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/runtime/extern.go View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/funcdata.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/malloc.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/mem.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/mgc0.c View 1 5 chunks +16 lines, -11 lines 0 comments Download
M src/runtime/print1.go View 1 1 chunk +6 lines, -21 lines 0 comments Download
M src/runtime/proc.c View 1 2 chunks +20 lines, -0 lines 0 comments Download
M src/runtime/rt0_nacl_amd64p32.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime.c View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime/stack.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/sys_nacl_amd64p32.s View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/time.go View 1 3 chunks +26 lines, -3 lines 0 comments Download
M src/syscall/fs_nacl.go View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/syscall/route_bsd.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/issue9006.go View 1 1 chunk +37 lines, -0 lines 0 comments Download
M test/maplinear.go View 1 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello austin (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...
10 years, 8 months ago (2014-10-29 15:08:04 UTC) #1
austin
LGTM. Looks like this shouldn't need any changes to power-specific files (the asm changes were ...
10 years, 8 months ago (2014-10-29 15:13:07 UTC) #2
rsc
10 years, 8 months ago (2014-10-29 15:45:07 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=5ad5e85cfb99 ***

[dev.power64] all: merge default (dd5014ed9b01) into dev.power64

Still passes on amd64.

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/165110043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b