Issue 164920044: [dev.power64] code review 164920044: liblink: power64 fixes and ports of changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 164920044: [dev.power64] code review 164920044: liblink: power64 fixes and ports of changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by austin

Modified:
10 years, 10 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

liblink: power64 fixes and ports of changes Ports of platform-specific changes that happened on default after dev.power64 forked (fixes for c2go, wrapper math fixes, moved stackguard field, stackguard1 support, precise stacks). Bug fixes (missing AMOVW in instruction table, correct unsigned 32-bit remainder).

Patch Set 1 #

Patch Set 2 : diff -r 29e7e33d4798fbcb2ce4d7fd5ae2aed3b17d1c5b https://code.google.com/p/go #

Patch Set 3 : diff -r 29e7e33d4798fbcb2ce4d7fd5ae2aed3b17d1c5b https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r d144154e739842cd0959483f052be7509d2cb915 https://code.google.com/p/go #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -127 lines)			Patch
	M	src/liblink/asm9.c	View	1	9 chunks	+17 lines, -52 lines	0 comments	Download
	M	src/liblink/obj9.c	View	1 2 3	9 chunks	+86 lines, -75 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

austin

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...

10 years, 10 months ago (2014-10-27 19:10:14 UTC) #1

rsc

LGTM https://codereview.appspot.com/164920044/diff/40001/src/liblink/obj9.c File src/liblink/obj9.c (right): https://codereview.appspot.com/164920044/diff/40001/src/liblink/obj9.c#newcode490 src/liblink/obj9.c:490: // It is a liblink NOP, not an ...

10 years, 10 months ago (2014-10-27 19:14:06 UTC) #2

austin

10 years, 10 months ago (2014-10-27 19:25:44 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5b8757de0290 ***

[dev.power64] liblink: power64 fixes and ports of changes

Ports of platform-specific changes that happened on default
after dev.power64 forked (fixes for c2go, wrapper math fixes,
moved stackguard field, stackguard1 support, precise stacks).
Bug fixes (missing AMOVW in instruction table, correct
unsigned 32-bit remainder).

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/164920044

Expand All Messages | Collapse All Messages