Insert stoptime throught database only

[calidion, 2010-06-11 02:08:51]

Insert stoptime throught database only

[weiliu, 2010-06-11 03:31:50]

http://codereview.appspot.com/1648042/diff/1/2
File transitfeed_editor.py (right):

http://codereview.appspot.com/1648042/diff/1/2#newcode586
transitfeed_editor.py:586: stopId, isEnd):
Insert what into Pattern? Please make it clear in your function name.

http://codereview.appspot.com/1648042/diff/1/2#newcode595
transitfeed_editor.py:595: query = ("update `%s` set stop_sequence =
stop_sequence + 1"
Why +1? Please add comments.

http://codereview.appspot.com/1648042/diff/1/2#newcode602
transitfeed_editor.py:602: # and the starting point of the ending point must
have this value
What does starting point of the ending point mean? I'm confused.

http://codereview.appspot.com/1648042/diff/1/2#newcode615
transitfeed_editor.py:615: 'trip_id=? order by stop_sequence ' + order + ' limit
1',
trip_id=?

http://codereview.appspot.com/1648042/diff/1/2#newcode617
transitfeed_editor.py:617: (arrival_time, departure_time) =
db._cursor.fetchone()
I don't understand why you use:
"if arrivalTime or departureTime" but still use:
(arrival_time, departure_time) = db._cursor.fetchone().

As we discussed previously, the logic of using the trip's end time is actually
wrong and should be fixed sometime. If you cannot fix it now, please add it as
TODO so that you won't forget it.

[calidion, 2010-06-11 07:27:05]

updated

http://codereview.appspot.com/1648042/diff/1/2
File transitfeed_editor.py (right):

http://codereview.appspot.com/1648042/diff/1/2#newcode586
transitfeed_editor.py:586: stopId, isEnd):
On 2010/06/11 03:31:50, weiliu wrote:
> Insert what into Pattern? Please make it clear in your function name.

Done.

http://codereview.appspot.com/1648042/diff/1/2#newcode595
transitfeed_editor.py:595: query = ("update `%s` set stop_sequence =
stop_sequence + 1"
On 2010/06/11 03:31:50, weiliu wrote:
> Why +1? Please add comments.

Done.

http://codereview.appspot.com/1648042/diff/1/2#newcode602
transitfeed_editor.py:602: # and the starting point of the ending point must
have this value
On 2010/06/11 03:31:50, weiliu wrote:
> What does starting point of the ending point mean? I'm confused.

Done.

http://codereview.appspot.com/1648042/diff/1/2#newcode617
transitfeed_editor.py:617: (arrival_time, departure_time) =
db._cursor.fetchone()
On 2010/06/11 03:31:50, weiliu wrote:
> I don't understand why you use:
> "if arrivalTime or departureTime" but still use:
> (arrival_time, departure_time) = db._cursor.fetchone().
> 
> As we discussed previously, the logic of using the trip's end time is actually
> wrong and should be fixed sometime. If you cannot fix it now, please add it as
> TODO so that you won't forget it.

Done.

[weiliu, 2010-06-12 02:35:42]

http://codereview.appspot.com/1648042/diff/4001/5001
File transitfeed_editor.py (right):

http://codereview.appspot.com/1648042/diff/4001/5001#newcode227
transitfeed_editor.py:227: 
Remove the blank line.

http://codereview.appspot.com/1648042/diff/4001/5001#newcode585
transitfeed_editor.py:585: def InsertStopTimeIntoPattern(db, patternId,
sequence, arrivalTime, departureTime,
Fix indentation.

http://codereview.appspot.com/1648042/diff/4001/5001#newcode609
transitfeed_editor.py:609: 
The following code is quite hacky, let's add it to our next plan to make it
right. As chatted offline, please make the comments clear enough so that other
people can understand.

[calidion, 2010-06-12 03:10:16]

http://codereview.appspot.com/1648042/diff/4001/5001
File transitfeed_editor.py (right):

http://codereview.appspot.com/1648042/diff/4001/5001#newcode227
transitfeed_editor.py:227: 
On 2010/06/12 02:35:42, weiliu wrote:
> Remove the blank line.

Done.

http://codereview.appspot.com/1648042/diff/4001/5001#newcode585
transitfeed_editor.py:585: def InsertStopTimeIntoPattern(db, patternId,
sequence, arrivalTime, departureTime,
On 2010/06/12 02:35:42, weiliu wrote:
> Fix indentation.

Done.

http://codereview.appspot.com/1648042/diff/4001/5001#newcode609
transitfeed_editor.py:609: 
On 2010/06/12 02:35:42, weiliu wrote:
> The following code is quite hacky, let's add it to our next plan to make it
> right. As chatted offline, please make the comments clear enough so that other
> people can understand.

Done.

[weiliu, 2010-06-12 03:13:31]

LGTM

Please fix the comment before submission.

http://codereview.appspot.com/1648042/diff/11001/8002
File transitfeed_editor.py (right):

http://codereview.appspot.com/1648042/diff/11001/8002#newcode610
transitfeed_editor.py:610: # TODO: don't add time at the end of the stoptime
TODO: add the correct departure/arrival time for the inserted stop.

[calidion, 2010-06-12 03:20:25]

updated to rev 95

2010/6/12 <weiliu@google.com>

> LGTM
>
> Please fix the comment before submission.
>
>
> http://codereview.appspot.com/1648042/diff/11001/8002
>
> File transitfeed_editor.py (right):
>
> http://codereview.appspot.com/1648042/diff/11001/8002#newcode610
> transitfeed_editor.py:610: # TODO: don't add time at the end of the
> stoptime
> TODO: add the correct departure/arrival time for the inserted stop.
>
>
> http://codereview.appspot.com/1648042/show
>