Issue 164660043: code review 164660043: freetype/truetype: update the golden tests for Ubuntu 1...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 164660043: code review 164660043: freetype/truetype: update the golden tests for Ubuntu 1... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by nigeltao

Modified:
9 years, 6 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-codereviews

Visibility:
Public.

Description

freetype/truetype: update the golden tests for Ubuntu 14.04's version of standard fonts like Deja Vu Sans Oblique.

Patch Set 1 #

Patch Set 2 : diff -r fe6099d37e696d890913122ac72ba7b1cf5e34bd https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r fe6099d37e696d890913122ac72ba7b1cf5e34bd https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r a123d4416a3c0d82f4b4ef320463306e7b4d2ec5 https://code.google.com/p/freetype-go #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
M	freetype/truetype/truetype_test.go	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	testdata/luximr.ttx	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	testdata/luxirr.ttx	View		1 chunk	+1 line, -1 line	0 comments	Download
M	testdata/luxisr.ttx	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	testdata/make-other-hinting-txts.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

9 years, 6 months ago (2014-11-06 09:06:28 UTC) #1

nigeltao

9 years, 6 months ago (2014-11-06 22:38:29 UTC) #3

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=4ee4916a76ae ***

freetype/truetype: update the golden tests for Ubuntu 14.04's version
of standard fonts like Deja Vu Sans Oblique.

LGTM=bsiegert
R=bsiegert
CC=golang-codereviews
https://codereview.appspot.com/164660043

Expand All Messages | Collapse All Messages