Issue 16440043: code review 16440043: freetype/truetype: implement GC and MD instructions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16440043: code review 16440043: freetype/truetype: implement GC and MD instructions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by remyoudompheng

Modified:
11 years, 1 month ago

Reviewers:
nigeltao

CC:
golang-dev, nigeltao, bsiegert

Visibility:
Public.

Description

freetype/truetype: implement GC and MD instructions. These instructions are found in Adobe Source Sans Pro fonts.

Patch Set 2 : diff -r 4289d0d71a69 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 4289d0d71a69 https://code.google.com/p/freetype-go #

Total comments: 3

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -5 lines)			Patch
	M	freetype/truetype/hint.go	View	1	1 chunk	+25 lines, -0 lines	2 comments	Download
	M	freetype/truetype/opcodes.go	View	1	2 chunks	+5 lines, -5 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com, nigeltao@golang.org, bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

11 years, 1 month ago (2013-10-24 04:32:06 UTC) #1

remyoudompheng

https://codereview.appspot.com/16440043/diff/40001/freetype/truetype/hint.go File freetype/truetype/hint.go (right): https://codereview.appspot.com/16440043/diff/40001/freetype/truetype/hint.go#newcode649 freetype/truetype/hint.go:649: p := h.point(0, unhinted, i) in this branch the ...

11 years, 1 month ago (2013-10-24 04:36:10 UTC) #2

nigeltao

LGTM, submitting... https://codereview.appspot.com/16440043/diff/40001/freetype/truetype/hint.go File freetype/truetype/hint.go (right): https://codereview.appspot.com/16440043/diff/40001/freetype/truetype/hint.go#newcode649 freetype/truetype/hint.go:649: p := h.point(0, unhinted, i) On 2013/10/24 ...

11 years, 1 month ago (2013-10-24 09:14:08 UTC) #3

nigeltao

11 years, 1 month ago (2013-10-24 09:18:14 UTC) #4

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=26099a7abb40 ***

freetype/truetype: implement GC and MD instructions.

These instructions are found in Adobe Source Sans Pro fonts.

R=golang-dev, nigeltao, bsiegert
CC=golang-dev
https://codereview.appspot.com/16440043

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages