code review 16430043: net/url: fix Encode doc comment

net/url: fix Encode doc comment

Encoded query strings are always sorted by key; the example wasn't.

[adg, 2013-10-24 04:22:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2013-10-24 04:25:27]

If we're going to promise that it'll be ordered by key then the
comment should say that explicitly.

[adg, 2013-10-24 04:50:46]

I agree. Happy to switch it to a guarantee in the comment if others agree.

Of course this can/should just wait until after 1.2.
On 24 Oct 2013 08:25, "David Symonds" <dsymonds@golang.org> wrote:

> If we're going to promise that it'll be ordered by key then the
> comment should say that explicitly.
>

[minux1, 2013-10-24 05:27:15]

if the ordering is guaranteed, why not make it explicit in the comment?

[bradfitz, 2013-10-24 15:56:39]

SGTM
 On Oct 23, 2013 9:25 PM, "David Symonds" <dsymonds@golang.org> wrote:

> If we're going to promise that it'll be ordered by key then the
> comment should say that explicitly.
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[adg, 2013-10-25 13:37:19]

Hello golang-dev@googlegroups.com, dsymonds@golang.org, minux.ma@gmail.com,
bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-10-25 17:42:29]

LGTM

[adg, 2013-10-25 20:00:26]

*** Submitted as https://code.google.com/p/go/source/detail?r=f9af8b83c78c ***

net/url: fix Encode doc comment

Encoded query strings are always sorted by key; the example wasn't.

R=golang-dev, dsymonds, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/16430043