Issue 164120043: code review 164120043: cmd/go: add get -f flag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 164120043: code review 164120043: cmd/go: add get -f flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

cmd/go: add get -f flag get -u now checks that remote repo paths match the ones predicted by the import paths: if you are get -u'ing rsc.io/pdf, it has to be checked out from the right location. This is important in case the rsc.io/pdf redirect changes. In some cases, people have good reasons to use non-standard remote repos. Add -f flag to allow that. The f can stand for force or fork, as you see fit. Fixes issue 8850.

Patch Set 1 #

Patch Set 2 : diff -r 420519ee6049c79f2a36a2e7c553adec992c104e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 420519ee6049c79f2a36a2e7c553adec992c104e https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r c3481212573b4f9ea5dcf1b43874ebcb546499a6 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
	M	src/cmd/go/get.go	View	1 2 3	5 chunks	+12 lines, -2 lines	0 comments	Download
	M	src/cmd/go/test.bash	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-28 03:03:48 UTC) #1

LGTM but maybe add the check https://codereview.appspot.com/164120043/diff/40001/src/cmd/go/get.go File src/cmd/go/get.go (right): https://codereview.appspot.com/164120043/diff/40001/src/cmd/go/get.go#newcode28 src/cmd/go/get.go:28: The -f flag ...

9 years, 6 months ago (2014-10-28 03:38:50 UTC) #2

rsc

9 years, 6 months ago (2014-10-28 15:14:31 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=0e9f68c2b11d ***

cmd/go: add get -f flag

get -u now checks that remote repo paths match the
ones predicted by the import paths: if you are get -u'ing
rsc.io/pdf, it has to be checked out from the right location.
This is important in case the rsc.io/pdf redirect changes.

In some cases, people have good reasons to use
non-standard remote repos. Add -f flag to allow that.
The f can stand for force or fork, as you see fit.

Fixes issue 8850.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/164120043

Expand All Messages | Collapse All Messages