code review 164090044: doc/go1.4.html: runtime and performance

doc/go1.4.html: runtime and performance

[r, 2014-10-28 00:51:25]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[adg1, 2014-10-28 01:04:07]

https://codereview.appspot.com/164090044/diff/1/doc/go1.4.html
File doc/go1.4.html (right):

https://codereview.appspot.com/164090044/diff/1/doc/go1.4.html#newcode110
doc/go1.4.html:110: A consequence is that stacks are no longer segmented,
eliminating the "hot split" problem.
This already changed in 1.3.
http://golang.org/doc/go1.3#stacks

[lucio, 2014-10-28 01:07:49]

Line 139: s/programs store/programs that store/

[r, 2014-10-28 01:13:37]

Hello golang-codereviews@googlegroups.com, adg@google.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[adg1, 2014-10-28 01:15:53]

LGTM

[bradfitz, 2014-10-28 01:41:18]

Not always, though.
 On Oct 27, 2014 8:04 PM, "adg via golang-codereviews" <
golang-codereviews@googlegroups.com> wrote:

>
> https://codereview.appspot.com/164090044/diff/1/doc/go1.4.html
> File doc/go1.4.html (right):
>
> https://codereview.appspot.com/164090044/diff/1/doc/go1.4.html#newcode110
> doc/go1.4.html:110: A consequence is that stacks are no longer
> segmented, eliminating the "hot split" problem.
> This already changed in 1.3.
> http://golang.org/doc/go1.3#stacks
>
> https://codereview.appspot.com/164090044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[dave_cheney.net, 2014-10-28 01:46:06]

Is it worth explaining this point.

"Copying stacks were introduced in the 1.3 release, but would in some
cases revert to the old split stack behaviour, making the change
incomplete. With the rewrite of the majority of the runtime to Go,
these exceptions which caused the reversion to the stack splitting
behaviour have been removed.'

On Tue, Oct 28, 2014 at 12:41 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Not always, though.
>
> On Oct 27, 2014 8:04 PM, "adg via golang-codereviews"
> <golang-codereviews@googlegroups.com> wrote:
>>
>>
>> https://codereview.appspot.com/164090044/diff/1/doc/go1.4.html
>> File doc/go1.4.html (right):
>>
>> https://codereview.appspot.com/164090044/diff/1/doc/go1.4.html#newcode110
>> doc/go1.4.html:110: A consequence is that stacks are no longer
>> segmented, eliminating the "hot split" problem.
>> This already changed in 1.3.
>> http://golang.org/doc/go1.3#stacks
>>
>> https://codereview.appspot.com/164090044/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[rsc, 2014-10-28 03:08:31]

LGTM

https://codereview.appspot.com/164090044/diff/30002/doc/go1.4.html
File doc/go1.4.html (right):

https://codereview.appspot.com/164090044/diff/30002/doc/go1.4.html#newcode104
doc/go1.4.html:104: (In 1.3 the heap was precise but not the stacks.)
I'd just delete this line.
The actual story is much more complex.
Both the heap and the stacks were mostly precise but not completely.
Now it is complete.

https://codereview.appspot.com/164090044/diff/30002/doc/go1.4.html#newcode114
doc/go1.4.html:114: Performance can be noticeably better in some cases and
always more predictable.
is there a verb missing after and? s/and/and is/?

[r, 2014-10-28 03:34:24]

Hello golang-codereviews@googlegroups.com, adg@google.com, bradfitz@golang.org,
dave@cheney.net, rsc@golang.org (cc: golang-codereviews@googlegroups.com),

Please take another look.

[r, 2014-10-28 03:34:44]

Hello golang-codereviews@googlegroups.com, adg@google.com, bradfitz@golang.org,
dave@cheney.net, rsc@golang.org (cc: golang-codereviews@googlegroups.com),

Please take another look.

[r, 2014-10-28 03:35:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=1684bfabd38a ***

doc/go1.4.html: runtime and performance

LGTM=adg, rsc
R=golang-codereviews, adg, bradfitz, dave, rsc
CC=golang-codereviews
https://codereview.appspot.com/164090044

[gobot, 2014-10-28 04:59:39]

This CL appears to have broken the linux-amd64-nocgo builder.
See http://build.golang.org/log/78b9b59ac23c81ba490326726d7b0a31d4c98e50