Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(688)

Issue 164070043: code review 164070043: test: make maplinear more robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rsc
Modified:
10 years, 4 months ago
Reviewers:
khr
CC:
khr, golang-codereviews, rlh
Visibility:
Public.

Description

test: make maplinear more robust The test just doubled a certain number of times and then gave up. On a mostly fast but occasionally slow machine this may never make the test run long enough to see the linear growth. Change test to keep doubling until the first round takes at least a full second, to reduce the effect of occasional scheduling or other jitter. The failure we saw had a time for the first round of around 100ms. Note that this test still passes once it sees a linear effect, even with a very small total time. The timeout here only applies to how long the execution must be to support a reported failure.

Patch Set 1 #

Patch Set 2 : diff -r 048e2219734a48af10087b48d08b00b8433ebad3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 048e2219734a48af10087b48d08b00b8433ebad3 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3a0dc093920326291d9c621ccb488d6f55d1159a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M test/maplinear.go View 1 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello khr (cc: golang-codereviews@googlegroups.com, rlh), I'd like you to review this change to https://code.google.com/p/go/
10 years, 4 months ago (2014-10-27 18:19:33 UTC) #1
khr
LGTM.
10 years, 4 months ago (2014-10-27 19:39:39 UTC) #2
rsc
10 years, 4 months ago (2014-10-27 22:59:14 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=774918103117 ***

test: make maplinear more robust

The test just doubled a certain number of times
and then gave up. On a mostly fast but occasionally
slow machine this may never make the test run
long enough to see the linear growth.

Change test to keep doubling until the first round
takes at least a full second, to reduce the effect of
occasional scheduling or other jitter.

The failure we saw had a time for the first round
of around 100ms.

Note that this test still passes once it sees a linear
effect, even with a very small total time.
The timeout here only applies to how long the execution
must be to support a reported failure.

LGTM=khr
R=khr
CC=golang-codereviews, rlh
https://codereview.appspot.com/164070043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b