Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 164010043: [dev.garbage] code review 164010043: runtime: Linear map test give false negative due to GC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rlh
Modified:
10 years, 4 months ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

runtime: Linear map test give false negative due to GC. This test gives a false negative at an observed rate of 1 in a 1000 due to the fact that it runs for < 100 ms. allowing GC pauses to warp the results. Changed the test so that it triggers only if it remains non-linear for much larger problem sizes.

Patch Set 1 #

Patch Set 2 : diff -r 1efe29eb33c51b77faf856c207d26ebe98852863 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1efe29eb33c51b77faf856c207d26ebe98852863 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/maplinear.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
rlh
Fix to linear map test.
10 years, 4 months ago (2014-10-27 17:57:28 UTC) #1
rsc
LGTM
10 years, 4 months ago (2014-10-27 18:09:46 UTC) #2
rlh
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.garbage branch ...
10 years, 4 months ago (2014-10-27 18:12:48 UTC) #3
rlh
*** Submitted as https://code.google.com/p/go/source/detail?r=9c8996c9926f *** [dev.garbage] runtime: Linear map test give false negative due to ...
10 years, 4 months ago (2014-10-27 18:12:58 UTC) #4
gobot
10 years, 4 months ago (2014-10-27 18:14:54 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/90c893f4110ff5887d4f0a7c5527791a2bc85db3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b