Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 16400043: Remove environs PublicStorage() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by wallyworld
Modified:
10 years, 6 months ago
Reviewers:
mp+192447, fwereade
Visibility:
Public.

Description

Remove environs PublicStorage() With the simplestreams tools infrastructure now in place, there is no longer any need for environment provided public storage. To ensure a clean environment config for 2.0, the relevant config attributes have been removed rather than deprecated. No one much uses them anyway eg public-bucket. https://code.launchpad.net/~wallyworld/juju-core/remove-public-storage/+merge/192447 Requires: https://code.launchpad.net/~wallyworld/juju-core/simplestreams-repository/+merge/192354 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -401 lines) Patch
[revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
cmd/juju/upgradejuju_test.go View 4 chunks +5 lines, -2 lines 0 comments Download
environs/bootstrap/bootstrap_test.go View 1 chunk +0 lines, -4 lines 0 comments Download
environs/config/config_test.go View 1 chunk +0 lines, -2 lines 0 comments Download
environs/interface.go View 1 chunk +0 lines, -3 lines 0 comments Download
environs/manual/provisioner_test.go View 2 chunks +0 lines, -2 lines 0 comments Download
environs/testing/tools.go View 1 chunk +0 lines, -2 lines 0 comments Download
provider/azure/config.go View 2 chunks +0 lines, -12 lines 0 comments Download
provider/azure/config_test.go View 3 chunks +6 lines, -32 lines 0 comments Download
provider/azure/environ.go View 4 chunks +0 lines, -33 lines 0 comments Download
provider/azure/environ_test.go View 2 chunks +0 lines, -34 lines 0 comments Download
provider/azure/environprovider_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
provider/azure/storage.go View 1 chunk +0 lines, -16 lines 0 comments Download
provider/dummy/environs.go View 3 chunks +13 lines, -16 lines 0 comments Download
provider/dummy/storage.go View 3 chunks +3 lines, -19 lines 0 comments Download
provider/ec2/config.go View 3 chunks +7 lines, -22 lines 0 comments Download
provider/ec2/config_test.go View 3 chunks +2 lines, -43 lines 0 comments Download
provider/ec2/ec2.go View 5 chunks +6 lines, -24 lines 0 comments Download
provider/ec2/export_test.go View 1 chunk +0 lines, -10 lines 0 comments Download
provider/ec2/live_test.go View 4 chunks +0 lines, -23 lines 0 comments Download
provider/ec2/local_test.go View 4 chunks +9 lines, -22 lines 0 comments Download
provider/local/environ.go View 1 chunk +0 lines, -5 lines 0 comments Download
provider/local/environ_test.go View 1 chunk +0 lines, -1 line 0 comments Download
provider/maas/environ.go View 1 chunk +0 lines, -6 lines 0 comments Download
provider/maas/environ_test.go View 1 chunk +0 lines, -7 lines 0 comments Download
provider/null/environ.go View 1 chunk +0 lines, -4 lines 0 comments Download
provider/openstack/config.go View 2 chunks +0 lines, -10 lines 0 comments Download
provider/openstack/config_test.go View 2 chunks +0 lines, -16 lines 0 comments Download
provider/openstack/export_test.go View 4 chunks +4 lines, -4 lines 0 comments Download
provider/openstack/local_test.go View 3 chunks +4 lines, -20 lines 0 comments Download
provider/openstack/provider.go View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2
wallyworld
Please take a look.
10 years, 6 months ago (2013-10-24 00:24:57 UTC) #1
fwereade
10 years, 6 months ago (2013-10-24 18:16:21 UTC) #2
This is the sexiest thing I have ever seen. LGTM. (make sure it works live etc
etc)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b