Add stop with database only

[calidion, 2010-06-12 08:38:17]

1.add Stop using database only
2.no longer using GTFS Objects in binding relationship between trip, shape and
pattern
3. change stop_id database storing type from char to integer

[calidion, 2010-06-12 08:43:23]

4. introduced svg failure due to not using objects, and we will modify the svg
display procedure soon
5. changed the pattern generating algorithm from turple the stop object to the
stop ip

On 2010/06/12 08:38:17, calidion wrote:
> 1.add Stop using database only
> 2.no longer using GTFS Objects in binding relationship between trip, shape and
> pattern
> 3. change stop_id database storing type from char to integer

[weiliu, 2010-06-13 03:26:58]

http://codereview.appspot.com/1634044/diff/3001/4002
File schedule_editor.py (right):

http://codereview.appspot.com/1634044/diff/3001/4002#newcode140
schedule_editor.py:140: maxId = EditableStop.GetInsertId(db)
This is not maxId, but max id + 1, right? Please rename it to newId or some
other name.

http://codereview.appspot.com/1634044/diff/3001/4001
File transitfeed_editor.py (left):

http://codereview.appspot.com/1634044/diff/3001/4001#oldcode1165
transitfeed_editor.py:1165: # when a route is selected and patterns of the route
are shown.
Update comments?

http://codereview.appspot.com/1634044/diff/3001/4001
File transitfeed_editor.py (right):

http://codereview.appspot.com/1634044/diff/3001/4001#newcode51
transitfeed_editor.py:51: 'float', 'char(256)', 'char(256)',
Can all stop_ids be converted to integer? For example, in one of the uk dataset,
the stop_id is "9400ZZGLBRI".

[calidion, 2010-06-13 07:12:16]

updated

http://codereview.appspot.com/1634044/diff/3001/4002
File schedule_editor.py (right):

http://codereview.appspot.com/1634044/diff/3001/4002#newcode140
schedule_editor.py:140: maxId = EditableStop.GetInsertId(db)
On 2010/06/13 03:26:59, weiliu wrote:
> This is not maxId, but max id + 1, right? Please rename it to newId or some
> other name.

Done.

http://codereview.appspot.com/1634044/diff/3001/4001
File transitfeed_editor.py (left):

http://codereview.appspot.com/1634044/diff/3001/4001#oldcode1165
transitfeed_editor.py:1165: # when a route is selected and patterns of the route
are shown.
On 2010/06/13 03:26:59, weiliu wrote:
> Update comments?

Done.

http://codereview.appspot.com/1634044/diff/3001/4001
File transitfeed_editor.py (right):

http://codereview.appspot.com/1634044/diff/3001/4001#newcode51
transitfeed_editor.py:51: 'float', 'char(256)', 'char(256)',
On 2010/06/13 03:26:59, weiliu wrote:
> Can all stop_ids be converted to integer? For example, in one of the uk
dataset,
> the stop_id is "9400ZZGLBRI".
I think we should limit the stop_id to be integer or we will have the difficulty
in generating new stop id automatically.

[calidion, 2010-06-13 07:51:53]

change the algorithm to generate stop id seeded by the current time

[weiliu, 2010-06-13 07:55:56]

LGTM

On Sun, Jun 13, 2010 at 3:51 PM, <calidion@gmail.com> wrote:

> change the algorithm to generate stop id seeded by the current time
>
>
> http://codereview.appspot.com/1634044/show
>



-- 
Best Regards,
Wei Liu
86-10-62503256(o)

[calidion, 2010-06-13 07:58:50]

updated to rev 96

2010/6/13 Wei Liu <weiliu@google.com>

> LGTM
>
>
> On Sun, Jun 13, 2010 at 3:51 PM, <calidion@gmail.com> wrote:
>
>> change the algorithm to generate stop id seeded by the current time
>>
>>
>> http://codereview.appspot.com/1634044/show
>>
>
>
>
> --
> Best Regards,
> Wei Liu
> 86-10-62503256(o)
>