Write shape points directly to database

[calidion, 2010-06-09 07:22:09]

1. added missing files
2. removed shape_id from Pattern
3. fixed a bug on fetching trips
4. Write shape points directly to database

[weiliu, 2010-06-09 09:37:14]

Please explain why:
- removed shape_id from Pattern
- what the bug is on fetching trips?

http://codereview.appspot.com/1633041/diff/1/2
File transitfeed_editor.py (right):

http://codereview.appspot.com/1633041/diff/1/2#newcode546
transitfeed_editor.py:546: return [1]
return 1 or [1]? Difference?

[calidion, 2010-06-09 09:45:50]

the bug is that we will fetch the wrong shape_id.
because trips having the same pattern in the same route can also have different
shape_ids, so the recorded shape_id in the pattern table can be wrong for the
trip.
if we edit the shape of a trip, the right shape may not be changed, and the
wrong shape will be changed.

http://codereview.appspot.com/1633041/diff/1/2
File transitfeed_editor.py (right):

http://codereview.appspot.com/1633041/diff/1/2#newcode546
transitfeed_editor.py:546: return [1]
On 2010/06/09 09:37:15, weiliu wrote:
> return 1 or [1]? Difference?

no difference between the return value, because the client won't process it.

more like a placeholder.

[weiliu, 2010-06-09 09:52:02]

On Wed, Jun 9, 2010 at 5:45 PM, <calidion@gmail.com> wrote:

> the bug is that we will fetch the wrong shape_id.
> because trips having the same pattern in the same route can also have
> different shape_ids, so the recorded shape_id in the pattern table can
> be wrong for the trip.
> if we edit the shape of a trip, the right shape may not be changed, and
> the wrong shape will be changed.
>
>
>
> http://codereview.appspot.com/1633041/diff/1/2
> File transitfeed_editor.py (right):
>
> http://codereview.appspot.com/1633041/diff/1/2#newcode546
> transitfeed_editor.py:546: return [1]
> On 2010/06/09 09:37:15, weiliu wrote:
>
>> return 1 or [1]? Difference?
>>
>
> no difference between the return value, because the client won't process
> it.
>
> more like a placeholder.
>
>
Can you change it to "return 1" to be consistent with others? Since you
won't use it anyway.

>
> http://codereview.appspot.com/1633041/show
>



-- 
Best Regards,
Wei Liu
86-10-62503256(o)

[calidion, 2010-06-09 09:54:40]

http://codereview.appspot.com/1633041/diff/1/2
File transitfeed_editor.py (right):

http://codereview.appspot.com/1633041/diff/1/2#newcode546
transitfeed_editor.py:546: return [1]
On 2010/06/09 09:37:15, weiliu wrote:
> return 1 or [1]? Difference?

Done.

[weiliu, 2010-06-09 09:56:05]

LGTM

On 2010/06/09 09:54:40, calidion wrote:
> http://codereview.appspot.com/1633041/diff/1/2
> File transitfeed_editor.py (right):
> 
> http://codereview.appspot.com/1633041/diff/1/2#newcode546
> transitfeed_editor.py:546: return [1]
> On 2010/06/09 09:37:15, weiliu wrote:
> > return 1 or [1]? Difference?
> 
> Done.

[calidion, 2010-06-09 09:57:48]

updated to rev 93

2010/6/9 <weiliu@google.com>

> LGTM
>
>
> On 2010/06/09 09:54:40, calidion wrote:
>
>> http://codereview.appspot.com/1633041/diff/1/2
>> File transitfeed_editor.py (right):
>>
>
>  http://codereview.appspot.com/1633041/diff/1/2#newcode546
>> transitfeed_editor.py:546: return [1]
>> On 2010/06/09 09:37:15, weiliu wrote:
>> > return 1 or [1]? Difference?
>>
>
>  Done.
>>
>
>
>
> http://codereview.appspot.com/1633041/show
>