Issue 162860043: code review 162860043: regexp: fix TestOnePassCutoff

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 162860043: code review 162860043: regexp: fix TestOnePassCutoff (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
r, iant

CC:
r, iant, bradfitz, golang-codereviews

Visibility:
Public.

Description

regexp: fix TestOnePassCutoff The stack blowout can no longer happen, but we can still test that too-complex regexps are rejected. Replacement for CL 162770043.

Patch Set 1 #

Patch Set 2 : diff -r 0588896d408d113ab8751136392d35a51b2ea7eb https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0588896d408d113ab8751136392d35a51b2ea7eb https://code.google.com/p/go/ #

Patch Set 4 : diff -r 0f645de063785747c74f23e00d9b890499028365 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/regexp/all_test.go	View	1	2 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: bradfitz, golang-codereviews@googlegroups.com, iant), I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-20 14:59:10 UTC) #1

rsc

9 years, 6 months ago (2014-10-20 16:16:50 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=a07b4f3a59e8 ***

regexp: fix TestOnePassCutoff

The stack blowout can no longer happen,
but we can still test that too-complex regexps
are rejected.

Replacement for CL 162770043.

LGTM=iant, r
R=r, iant
CC=bradfitz, golang-codereviews
https://codereview.appspot.com/162860043

Expand All Messages | Collapse All Messages