Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 162390043: code review 162390043: os: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rsc
Modified:
10 years, 4 months ago
Reviewers:
crawshaw
CC:
golang-codereviews
Visibility:
Public.

Description

os: fix build

Patch Set 1 #

Patch Set 2 : diff -r 723cc35d358383537c1ca258ba0539f9ad1644c5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 814c34722d34971f2a744e98a50a7d183af2a910 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/os/file_unix.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello crawshaw (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 4 months ago (2014-10-28 19:34:49 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=154674021c55 *** os: fix build TBR=crawshaw CC=golang-codereviews https://codereview.appspot.com/162390043
10 years, 4 months ago (2014-10-28 19:34:55 UTC) #2
crawshaw
LGTM for fixing the build, but I think lseek returns -1 on error. Is letting ...
10 years, 4 months ago (2014-10-28 19:42:25 UTC) #3
rsc
10 years, 4 months ago (2014-10-28 19:49:14 UTC) #4
seek returns an absolute offset, not a count, so i don't care much.
it's not going to get incorrect added to a running total.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b