Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2284)

Issue 162370045: code review 162370045: doc/go1.4.html: new ports (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by r
Modified:
10 years, 4 months ago
Reviewers:
aram, minux, rsc
CC:
golang-codereviews, aram, minux, rsc
Visibility:
Public.

Description

doc/go1.4.html: new ports

Patch Set 1 #

Patch Set 2 : diff -r 4d78f41ca8c93c3ec3f51fc9fea3cbfe12b5af9e https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 4d78f41ca8c93c3ec3f51fc9fea3cbfe12b5af9e https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 723cc35d358383537c1ca258ba0539f9ad1644c5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M doc/go1.4.html View 1 2 3 7 chunks +31 lines, -8 lines 0 comments Download

Messages

Total messages: 11
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2014-10-28 18:07:57 UTC) #1
aram
This is the first releas with working plan9/amd64. Do you want to mention it now, ...
10 years, 4 months ago (2014-10-28 18:18:17 UTC) #2
r
I'll put it in. -rob On Tue, Oct 28, 2014 at 11:18 AM, <aram@mgk.ro> wrote: ...
10 years, 4 months ago (2014-10-28 18:20:38 UTC) #3
r
Hello golang-codereviews@googlegroups.com, aram@mgk.ro (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 4 months ago (2014-10-28 18:21:45 UTC) #4
minux
https://codereview.appspot.com/162370045/diff/20001/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/162370045/diff/20001/doc/go1.4.html#newcode99 doc/go1.4.html:99: architecture (using 32-bit pointers). nacl is supported on both ...
10 years, 4 months ago (2014-10-28 18:25:51 UTC) #5
aram
https://codereview.appspot.com/162370045/diff/20001/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/162370045/diff/20001/doc/go1.4.html#newcode106 doc/go1.4.html:106: This release adds support for the Plan 9 operating ...
10 years, 4 months ago (2014-10-28 18:28:13 UTC) #6
r
Hello golang-codereviews@googlegroups.com, aram@mgk.ro, minux@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 4 months ago (2014-10-28 18:39:54 UTC) #7
rsc
LGTM
10 years, 4 months ago (2014-10-28 18:45:28 UTC) #8
aram
LGTM
10 years, 4 months ago (2014-10-28 19:06:39 UTC) #9
minux
LGTM. https://codereview.appspot.com/162370045/diff/40001/doc/go1.4.html File doc/go1.4.html (right): https://codereview.appspot.com/162370045/diff/40001/doc/go1.4.html#newcode100 doc/go1.4.html:100: and 64-bit x86 using 32-bit pointers (GOARCH=amd64p32). <code> ...
10 years, 4 months ago (2014-10-28 19:11:28 UTC) #10
r
10 years, 4 months ago (2014-10-28 19:11:38 UTC) #11
*** Submitted as https://code.google.com/p/go/source/detail?r=814c34722d34 ***

doc/go1.4.html: new ports

LGTM=rsc, aram, minux
R=golang-codereviews, aram, minux, rsc
CC=golang-codereviews
https://codereview.appspot.com/162370045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b