Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 162340043: code review 162340043: encoding/json: encode \t as \t instead of \u0009 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rsc
Modified:
9 years, 7 months ago
Reviewers:
gobot, bradfitz
CC:
adg, bradfitz, golang-codereviews, zimmski
Visibility:
Public.

Description

encoding/json: encode \t as \t instead of \u0009 Shorter and easier to read form for a common character.

Patch Set 1 #

Patch Set 2 : diff -r 048e2219734a48af10087b48d08b00b8433ebad3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 048e2219734a48af10087b48d08b00b8433ebad3 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2e3b9114d5296a78d2b06342add44d6bfb437b1d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1 line) Patch
M src/encoding/json/encode.go View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/encoding/json/encode_test.go View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello adg (cc: golang-codereviews@googlegroups.com, zimmski@gmail.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 7 months ago (2014-10-27 19:55:49 UTC) #1
bradfitz
LGTM On Oct 27, 2014 12:55 PM, <rsc@golang.org> wrote: > Reviewers: adg, > > Message: ...
9 years, 7 months ago (2014-10-27 19:57:06 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=3a0dc0939203 *** encoding/json: encode \t as \t instead of \u0009 Shorter and ...
9 years, 7 months ago (2014-10-27 22:58:31 UTC) #3
gobot
This CL appears to have broken the linux-amd64 builder. See http://build.golang.org/log/cb88d5667932be6293bad8c255131dc8fcc4a5ae
9 years, 7 months ago (2014-10-27 23:00:49 UTC) #4
adg
9 years, 7 months ago (2014-10-27 23:07:10 UTC) #5
This failure is real.

On Tue Oct 28 2014 at 10:00:53 AM <gobot@golang.org> wrote:

> This CL appears to have broken the linux-amd64 builder.
> See http://build.golang.org/log/cb88d5667932be6293bad8c255131dc8fcc4a5ae
>
> https://codereview.appspot.com/162340043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b