Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2200)

Issue 162060043: code review 162060043: unsafe: document that unsafe programs are not protected (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by r
Modified:
9 years, 6 months ago
Reviewers:
gobot, rsc, gri, bradfitz
CC:
golang-codereviews, bradfitz, gri, rsc
Visibility:
Public.

Description

unsafe: document that unsafe programs are not protected The compatibility guideline needs to be clear about this even though it means adding a clause that was not there from the beginning. It has always been understood, so this isn't really a change in policy, just in its expression.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 14e0f632a0b4d4820aea053090338d40c0068730 https://code.google.com/p/go #

Patch Set 3 : diff -r 048e2219734a48af10087b48d08b00b8433ebad3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M doc/go1compat.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/unsafe/unsafe.go View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2014-10-23 15:59:36 UTC) #1
bradfitz
LGTM
9 years, 7 months ago (2014-10-23 16:06:30 UTC) #2
gri
LGTM https://codereview.appspot.com/162060043/diff/1/doc/go1compat.html File doc/go1compat.html (right): https://codereview.appspot.com/162060043/diff/1/doc/go1compat.html#newcode108 doc/go1compat.html:108: Use of <code>unsafe</code>. Packages that import the s/of ...
9 years, 7 months ago (2014-10-23 16:42:35 UTC) #3
r
Hello golang-codereviews@googlegroups.com, bradfitz@golang.org, gri@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 7 months ago (2014-10-23 16:43:40 UTC) #4
gri
LGTM
9 years, 7 months ago (2014-10-23 16:44:36 UTC) #5
rsc
LGTM
9 years, 7 months ago (2014-10-24 00:15:50 UTC) #6
r
*** Submitted as https://code.google.com/p/go/source/detail?r=20e544e3b39e *** unsafe: document that unsafe programs are not protected The compatibility ...
9 years, 7 months ago (2014-10-24 16:37:30 UTC) #7
gobot
9 years, 6 months ago (2014-10-26 23:24:20 UTC) #8
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64-nocgo builder.
See http://build.golang.org/log/d7a5849378eb38de7f045b3cc18db127fb813774
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b