Issue 161320043: [dev.power64] code review 161320043: liblink: print line numbers in disassembly on power64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 161320043: [dev.power64] code review 161320043: liblink: print line numbers in disassembly on power64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by austin

Modified:
10 years, 4 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

liblink: print line numbers in disassembly on power64 Matching other platforms.

Patch Set 1 #

Patch Set 2 : diff -r 3f05c467402bcf21bbc971ffc2083a6e031bfe94 https://code.google.com/p/go #

Patch Set 3 : diff -r 3f05c467402bcf21bbc971ffc2083a6e031bfe94 https://code.google.com/p/go #

Patch Set 4 : diff -r 3f05c467402bcf21bbc971ffc2083a6e031bfe94 https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/liblink/list9.c	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

austin

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...

10 years, 4 months ago (2014-10-24 15:31:13 UTC) #1

austin

*** Submitted as https://code.google.com/p/go/source/detail?r=29e7e33d4798 *** [dev.power64] liblink: print line numbers in disassembly on power64 Matching ...

10 years, 4 months ago (2014-10-24 15:39:07 UTC) #3

gobot

10 years, 4 months ago (2014-10-24 15:58:33 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the darwin-amd64-cheney builder.
See http://build.golang.org/log/54274faead3c1a594ed205bfe316eeaed192f805

Expand All Messages | Collapse All Messages