Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2285)

Issue 160600043: code review 160600043: doc/go1.4.html: much of the go command's changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by r
Modified:
10 years, 4 months ago
Reviewers:
gobot, rsc, adg1
CC:
golang-codereviews, adg1
Visibility:
Public.

Description

doc/go1.4.html: much of the go command's changes still need to do internal and import comments

Patch Set 1 #

Patch Set 2 : diff -r 1684bfabd38a780af2e9ca49d9fc4bd5cf95628c https://code.google.com/p/go/ #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -51 lines) Patch
M doc/go1.4.html View 3 chunks +127 lines, -51 lines 4 comments Download

Messages

Total messages: 5
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 4 months ago (2014-10-28 04:28:48 UTC) #1
adg1
LGTM
10 years, 4 months ago (2014-10-28 05:02:25 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=c0c7fc02a32d *** doc/go1.4.html: much of the go command's changes still need to ...
10 years, 4 months ago (2014-10-28 05:47:53 UTC) #3
gobot
This CL appears to have broken the windows-amd64 builder. See http://build.golang.org/log/26db4d082808da7f5cab2f6d848a7e641068f082
10 years, 4 months ago (2014-10-28 06:02:01 UTC) #4
rsc
10 years, 4 months ago (2014-10-28 14:49:07 UTC) #5
Message was sent while issue was closed.
LGTM

https://codereview.appspot.com/160600043/diff/20001/doc/go1.4.html
File doc/go1.4.html (right):

https://codereview.appspot.com/160600043/diff/20001/doc/go1.4.html#newcode196
doc/go1.4.html:196: For example, it can be used to run the <a
href="http://en.wikipedia.org/wiki/Yacc"><code>yacc</code></a>
i was going to suggest
http://dinosaur.compilertools.net/yacc/,
but the right link is probably /cmd/yacc/.

https://codereview.appspot.com/160600043/diff/20001/doc/go1.4.html#newcode229
doc/go1.4.html:229: Files with names like <code>windows.go</code> or
<code>arm64.go</code> should either
did you mean amd64?
we don't have arm64 yet.

https://codereview.appspot.com/160600043/diff/20001/doc/go1.4.html#newcode263
doc/go1.4.html:263: The <a href="/cmd/go/#hdr-Test_packages"><code>go</code>
<code>test</code></a>
s/$/ subcommand/

https://codereview.appspot.com/160600043/diff/20001/doc/go1.4.html#newcode271
doc/go1.4.html:271: <a href="/cmd/go/#hdr-Test_packages"><code>go</code>
<code>build</code></a>'s
s/'s/ subcommand's/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b