Get Shape points by trip id from database

[calidion, 2010-06-08 06:53:59]

Get Shape points by trip id from database

[weiliu, 2010-06-08 06:58:07]

http://codereview.appspot.com/1602041/diff/1/3
File schedule_editor.py (right):

http://codereview.appspot.com/1602041/diff/1/3#newcode321
schedule_editor.py:321: 
Why do you need trip_id when fetching a shape? Isn't shape_id enough?

[calidion, 2010-06-08 07:05:27]

2010/6/8 <weiliu@google.com>

>
> http://codereview.appspot.com/1602041/diff/1/3
> File schedule_editor.py (right):
>
> http://codereview.appspot.com/1602041/diff/1/3#newcode321
> schedule_editor.py:321:
> Why do you need trip_id when fetching a shape? Isn't shape_id enough?

 we find the shape_id through the trip_id

>
>
> http://codereview.appspot.com/1602041/show
>

[weiliu, 2010-06-08 07:07:12]

On Tue, Jun 8, 2010 at 3:05 PM, <李白> wrote:

>
>
> 2010/6/8 <weiliu@google.com>
>
>
>> http://codereview.appspot.com/1602041/diff/1/3
>> File schedule_editor.py (right):
>>
>> http://codereview.appspot.com/1602041/diff/1/3#newcode321
>> schedule_editor.py:321:
>> Why do you need trip_id when fetching a shape? Isn't shape_id enough?
>
>  we find the shape_id through the trip_id
>

But you pass the trip.shape_id to fetch it, right?

>
>>
>> http://codereview.appspot.com/1602041/show
>>
>
>


-- 
Best Regards,
Wei Liu
86-10-62503256(o)

[weiliu, 2010-06-08 07:12:26]

http://codereview.appspot.com/1602041/diff/1/2
File transitfeed_editor.py (right):

http://codereview.appspot.com/1602041/diff/1/2#newcode674
transitfeed_editor.py:674: def GetShape(db, tid):
I understand now, please rename GetShape to GetShapePointsByTripId.

[calidion, 2010-06-08 07:12:32]

2010/6/8 Wei Liu <weiliu@google.com>

>
>
> On Tue, Jun 8, 2010 at 3:05 PM, <李白> wrote:
>
>>
>>
>> 2010/6/8 <weiliu@google.com>
>>
>>
>>> http://codereview.appspot.com/1602041/diff/1/3
>>> File schedule_editor.py (right):
>>>
>>> http://codereview.appspot.com/1602041/diff/1/3#newcode321
>>> schedule_editor.py:321:
>>> Why do you need trip_id when fetching a shape? Isn't shape_id enough?
>>
>>  we find the shape_id through the trip_id
>>
>
> But you pass the trip.shape_id to fetch it, right?
>
yes, we don't know the shape id if we don't query table trips .

>
>>>
>>> http://codereview.appspot.com/1602041/show
>>>
>>
>>
>
>
> --
> Best Regards,
> Wei Liu
> 86-10-62503256(o)
>

[calidion, 2010-06-08 07:20:43]

http://codereview.appspot.com/1602041/diff/1/2
File transitfeed_editor.py (right):

http://codereview.appspot.com/1602041/diff/1/2#newcode674
transitfeed_editor.py:674: def GetShape(db, tid):
On 2010/06/08 07:12:27, weiliu wrote:
> I understand now, please rename GetShape to GetShapePointsByTripId.

Done.

[weiliu, 2010-06-08 09:45:06]

LGTM

On Tue, Jun 8, 2010 at 3:20 PM, <calidion@gmail.com> wrote:

>
> http://codereview.appspot.com/1602041/diff/1/2
> File transitfeed_editor.py (right):
>
> http://codereview.appspot.com/1602041/diff/1/2#newcode674
> transitfeed_editor.py:674: def GetShape(db, tid):
> On 2010/06/08 07:12:27, weiliu wrote:
>
>> I understand now, please rename GetShape to GetShapePointsByTripId.
>>
>
> Done.
>
>
> http://codereview.appspot.com/1602041/show
>



-- 
Best Regards,
Wei Liu
86-10-62503256(o)

[calidion, 2010-06-08 09:47:10]

updated to rev 91

2010/6/8 Wei Liu <weiliu@google.com>

> LGTM
>
>
> On Tue, Jun 8, 2010 at 3:20 PM, <calidion@gmail.com> wrote:
>
>>
>> http://codereview.appspot.com/1602041/diff/1/2
>> File transitfeed_editor.py (right):
>>
>> http://codereview.appspot.com/1602041/diff/1/2#newcode674
>> transitfeed_editor.py:674: def GetShape(db, tid):
>> On 2010/06/08 07:12:27, weiliu wrote:
>>
>>> I understand now, please rename GetShape to GetShapePointsByTripId.
>>>
>>
>> Done.
>>
>>
>> http://codereview.appspot.com/1602041/show
>>
>
>
>
> --
> Best Regards,
> Wei Liu
> 86-10-62503256(o)
>