Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 1601044: Move CajaHostingModules example and supporting files into repository. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by kpreid2
Modified:
13 years, 8 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The example from the CajaHostingModules wiki page is moved into the repository, next to Jasvir's simple dynamic-loading host page. An Ant build rule 'containers' copies all files and cajoles gadgets into ant-www/. This is a draft for design review and should not yet be committed.

Patch Set 1 #

Patch Set 2 : Move CajaHostingModules example and supporting files into repository. #

Patch Set 3 : Move CajaHostingModules example and supporting files into repository. #

Total comments: 3

Patch Set 4 : Move CajaHostingModules example and supporting files into repository. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -76 lines) Patch
M build.xml View 1 2 3 2 chunks +39 lines, -1 line 0 comments Download
A + src/com/google/caja/demos/container/container-dynamic.html View 3 chunks +15 lines, -8 lines 0 comments Download
A src/com/google/caja/demos/container/container-interaction.html View 1 2 3 1 chunk +167 lines, -0 lines 0 comments Download
A src/com/google/caja/demos/container/gadget-get.html View 1 chunk +2 lines, -0 lines 0 comments Download
A src/com/google/caja/demos/container/gadget-library.html View 1 chunk +5 lines, -0 lines 0 comments Download
A src/com/google/caja/demos/container/gadget-set.html View 1 chunk +2 lines, -0 lines 0 comments Download
D src/com/google/caja/demos/container/index.html View 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 5
kpreid1
15 years, 10 months ago (2010-06-10 02:31:27 UTC) #1
kpreid1
15 years, 10 months ago (2010-06-10 20:08:56 UTC) #2
Jasvir
LGTM http://codereview.appspot.com/1601044/diff/5001/6006 File build.xml (right): http://codereview.appspot.com/1601044/diff/5001/6006#newcode1050 build.xml:1050: <output file="${lib}/com/google/caja/demos/container/gadget-library.out.js" Line wrap at 80 please and ...
15 years, 10 months ago (2010-06-10 20:29:34 UTC) #3
kpreid1
15 years, 10 months ago (2010-06-10 20:47:33 UTC) #4
Jasvir
15 years, 10 months ago (2010-06-10 20:57:33 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b