Issue 1599041: Get stoptimes by trip id from database

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1599041: Get stoptimes by trip id from database

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by calidion

Modified:
7 years, 4 months ago

Reviewers:
xan, weiliu, baiming, leio.chen, lychen

CC:
xinxing_google.com, lishuangfeng_gmail.com

Base URL:
http://scheduleeditor.googlecode.com/svn/trunk/v2/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -12 lines)			Patch
	M	schedule_editor.py	View		1 chunk	+13 lines, -12 lines	0 comments	Download
	M	transitfeed_editor.py	View		1 chunk	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

weiliu

LGTM http://codereview.appspot.com/1599041/diff/1/2 File transitfeed_editor.py (right): http://codereview.appspot.com/1599041/diff/1/2#newcode631 transitfeed_editor.py:631: def GetByTripId(db, tid): GetStoptimesByTripId

13 years, 10 months ago (2010-06-08 06:06:56 UTC) #2

calidion

13 years, 10 months ago (2010-06-08 06:16:06 UTC) #3

updated to rev 90

2010/6/8 <weiliu@google.com>

> LGTM
>
>
> http://codereview.appspot.com/1599041/diff/1/2
> File transitfeed_editor.py (right):
>
> http://codereview.appspot.com/1599041/diff/1/2#newcode631
> transitfeed_editor.py:631: def GetByTripId(db, tid):
> GetStoptimesByTripId
>
>
> http://codereview.appspot.com/1599041/show
>

Expand All Messages | Collapse All Messages