Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 15980043: Update to onboarding (proposing for ant)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by jeff.pihach
Modified:
11 years ago
Reviewers:
mp+192273, gary.poster
Visibility:
Public.

Description

Update to onboarding (proposing for ant) Removed Flag Added a mask of the header at all time with the logo attached. Inishal onboarding is now fully masked. https://code.launchpad.net/~hatch/juju-gui/onboarding-continued/+merge/192273 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update to onboarding (proposing for ant) #

Patch Set 3 : Update to onboarding (proposing for ant) #

Patch Set 4 : Update to onboarding (proposing for ant) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/images/non-sprites/onboarding/3-inspector.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M app/subapps/browser/browser.js View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/onboarding.handlebars View 1 1 chunk +7 lines, -8 lines 0 comments Download
M lib/views/browser/onboarding.less View 1 4 chunks +9 lines, -5 lines 0 comments Download
M test/test_browser_app.js View 1 2 3 5 chunks +3 lines, -10 lines 0 comments Download
M test/test_onboarding.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
11 years ago (2013-10-23 01:16:44 UTC) #1
gary.poster
Code LGTM. I'll qa in a sec.
11 years ago (2013-10-23 04:04:06 UTC) #2
gary.poster
QA *not ok*, but this should be a pretty easy fix. The image of the ...
11 years ago (2013-10-23 05:49:59 UTC) #3
gary.poster
On 2013/10/23 05:49:59, gary.poster wrote: > QA *not ok*, but this should be a pretty ...
11 years ago (2013-10-23 17:24:08 UTC) #4
jeff.pihach
11 years ago (2013-10-25 23:11:55 UTC) #5
*** Submitted:

Update to onboarding (proposing for ant)

Removed Flag
Added a mask of the header at all time with the logo attached. Inishal
onboarding is now fully masked.

R=gary.poster
CC=
https://codereview.appspot.com/15980043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b