Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 159800043: code review 159800043: goprotobuf: Make text parsing functions return Required... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dsymonds
Modified:
11 years, 1 month ago
Reviewers:
gmlewis1
CC:
gmlewis1, golang-codereviews
Visibility:
Public.

Description

goprotobuf: Make text parsing functions return RequiredNotSetError as appropriate. This permits a program to ignore unset required fields when decoding text just as they can already do when decoding the wire format. It has the downside of no longer always returning a ParseError unfortunately.

Patch Set 1 #

Patch Set 2 : diff -r f123757c0387df47ab2d2009c2fbefbef5f944e9 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r f123757c0387df47ab2d2009c2fbefbef5f944e9 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r f123757c0387df47ab2d2009c2fbefbef5f944e9 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M proto/text_parser.go View 1 7 chunks +19 lines, -12 lines 0 comments Download
M proto/text_parser_test.go View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello gmlewis@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
11 years, 1 month ago (2014-10-12 05:38:01 UTC) #1
gmlewis1
LGTM
11 years, 1 month ago (2014-10-12 05:42:11 UTC) #2
dsymonds
11 years, 1 month ago (2014-10-12 05:42:48 UTC) #3
*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=9608ff8e4050 ***

goprotobuf: Make text parsing functions return RequiredNotSetError as
appropriate.

This permits a program to ignore unset required fields when decoding text
just as they can already do when decoding the wire format.
It has the downside of no longer always returning a ParseError unfortunately.

LGTM=gmlewis
R=gmlewis
CC=golang-codereviews
https://codereview.appspot.com/159800043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b