Issue 159600043: code review 159600043: syscall: accept pre-existing directories in nacl zip file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 159600043: code review 159600043: syscall: accept pre-existing directories in nacl zip file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by rsc

Modified:
10 years, 4 months ago

Reviewers:
adg1

CC:
adg, adg1, golang-codereviews

Visibility:
Public.

Description

syscall: accept pre-existing directories in nacl zip file NaCl creates /tmp. This lets the zip file populate it.

Patch Set 1 #

Patch Set 2 : diff -r c283a21e89c5f16ce56db3a084494674171c0d49 https://code.google.com/p/go/ #

Patch Set 3 : diff -r daf0179cc57600d8a960cf857ef22c5f6b66ef3b https://code.google.com/p/go/ #

Patch Set 4 : diff -r daf0179cc57600d8a960cf857ef22c5f6b66ef3b https://code.google.com/p/go/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/syscall/fs_nacl.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 4 months ago (2014-10-28 00:35:27 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=cebab42ec552 *** syscall: accept pre-existing directories in nacl zip file NaCl creates ...

10 years, 4 months ago (2014-10-28 00:45:21 UTC) #4

rsc

10 years, 4 months ago (2014-10-28 00:45:49 UTC) #5

Message was sent while issue was closed.

On 2014/10/28 00:42:06, adg1 wrote:
> create is used to create directories?

sure, why not. they're just files whose contents have special meaning.

Expand All Messages | Collapse All Messages