Issue 159590043: code review 159590043: html/template: fix build after encoding/js escaping change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 159590043: code review 159590043: html/template: fix build after encoding/js escaping change (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by adg

Modified:
10 years, 4 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

html/template: fix build after encoding/js escaping change

Patch Set 1 #

Patch Set 2 : diff -r 77491810311751b45f0ad137f200b134f98d73b2 https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/html/template/js_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 4 months ago (2014-10-27 23:15:07 UTC) #1

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 4 months ago (2014-10-27 23:15:07 UTC) #2

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=849dcf4fd495 *** html/template: fix build after encoding/js escaping change TBR=rsc R=golang-codereviews CC=golang-codereviews ...

10 years, 4 months ago (2014-10-27 23:18:47 UTC) #3

LGTM

thanks

Expand All Messages | Collapse All Messages