Issue 159130044: code review 159130044: runtime: handle non-nil-terminated environment strings ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 159130044: code review 159130044: runtime: handle non-nil-terminated environment strings ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by 0intro

Modified:
10 years, 4 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: handle non-nil-terminated environment strings on Plan 9 Russ Cox pointed out that environment strings are not required to be nil-terminated on Plan 9.

Patch Set 1 #

Patch Set 2 : diff -r 6d6fbf7dee5bf39f628cd1b2e4108a35955788fe https://code.google.com/p/go #

Patch Set 3 : diff -r 6d6fbf7dee5bf39f628cd1b2e4108a35955788fe https://code.google.com/p/go #

Patch Set 4 : diff -r f84cfd882eca482a39e097e8b6d791672720b6e6 https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/runtime/env_plan9.go	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 4 months ago (2014-10-20 20:19:40 UTC) #1

0intro

*** Submitted as https://code.google.com/p/go/source/detail?r=3484e15daca1 *** runtime: handle non-nil-terminated environment strings on Plan 9 Russ Cox ...

10 years, 4 months ago (2014-10-20 21:03:32 UTC) #3

gobot

10 years, 4 months ago (2014-10-20 22:07:19 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/7c5bdbf07ee2b83d097fdaa0fa9436e79d6600d1

Expand All Messages | Collapse All Messages