Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(787)

Issue 159120044: code review 159120044: compress/gzip: allow stopping at end of first stream (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by rsc
Modified:
9 years, 9 months ago
Reviewers:
nigeltao, gobot
CC:
nigeltao, kortschak, adg, bradfitz, golang-codereviews, r
Visibility:
Public.

Description

compress/gzip: allow stopping at end of first stream Allows parsing some file formats that assign special meaning to which stream data is found in. Will do the same for compress/bzip2 once this is reviewed and submitted. Fixes issue 6486.

Patch Set 1 #

Patch Set 2 : diff -r 6d6fbf7dee5bf39f628cd1b2e4108a35955788fe https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6d6fbf7dee5bf39f628cd1b2e4108a35955788fe https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5d69cad4faaf71fa001e1ed4cdbcde1de9b03643 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M src/compress/gzip/gunzip.go View 1 4 chunks +27 lines, -0 lines 0 comments Download
M src/compress/gzip/gunzip_test.go View 1 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello nigeltao (cc: adg, bradfitz, golang-codereviews@googlegroups.com, r), I'd like you to review this change to ...
9 years, 9 months ago (2014-10-20 21:34:17 UTC) #1
kortschak
Very nice. Thank you.
9 years, 9 months ago (2014-10-20 22:50:44 UTC) #2
nigeltao
LGTM.
9 years, 9 months ago (2014-10-21 01:20:02 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=c31876cc01e9 *** compress/gzip: allow stopping at end of first stream Allows parsing ...
9 years, 9 months ago (2014-10-21 02:03:51 UTC) #4
rsc
I take it back. I am NOT making the same change to bzip2. There is ...
9 years, 9 months ago (2014-10-21 02:10:52 UTC) #5
gobot
9 years, 9 months ago (2014-10-21 04:04:40 UTC) #6
Message was sent while issue was closed.
This changed caused perf changes on windows-amd64-perf:


json-1                    old          new      delta
rss                  62550016     68612096      +9.69
sys-gc                3107388      3463740     +11.47
sys-total            57448760     63510840     +10.55

json-8                    old          new      delta
rss                 181248000    201818112     +11.35
sys-gc               10086972     11356732     +12.59
sys-total           174905656    196856120     +12.55

json-16                   old          new      delta
rss                 324767744    390537216     +20.25
sys-gc               18631228     22444604     +20.47
sys-total           318378280    383849192     +20.56

http://build.golang.org/perfdetail?commit=c31876cc01e949e1be6f707f51b980d3963...



—gobot
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b