Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1633)

Issue 159050043: Issue 461: LilyPond should accept a tie between notes which are enharmonically identical (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dak
Modified:
8 years, 5 months ago
Reviewers:
lemzwerg, uliska
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 461: LilyPond should accept a tie between notes which are enharmonically identical This patch connects the respective notes in Tie_engraver and Tie_performer as a fallback after exhausting regular tie associations. It also keeps the accidental engraver from applying its special rules for tied notes that don't have exactly matching pitches. No attempt is made to adjust the visuals of the ties: they will remain horizontal, focused on the left note head.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -5 lines) Patch
A input/regression/tie-enharmonic.ly View 1 chunk +18 lines, -0 lines 0 comments Download
M lily/accidental-engraver.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M lily/tie-engraver.cc View 6 chunks +24 lines, -5 lines 0 comments Download
M lily/tie-performer.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
Very nice! Thanks for implementing this feature. LGTM.
9 years, 6 months ago (2014-10-18 14:50:58 UTC) #1
uliska
9 years, 6 months ago (2014-10-18 18:02:15 UTC) #2
LGTM too.

Of course this doesn't look right out-of-the-box (maybe it would be good to let
the Tie being printed as a Slur instead). But as one can use \shape it's at
least possible to use that as a working and semantically correct solution.
It even works with cross-staff ties (although I suspect that their layout is
very fragile).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b