Issue 15900044: code review 15900044: googleapi: add types for slices of numbers that marshal...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15900044: code review 15900044: googleapi: add types for slices of numbers that marshal... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bradfitz

Modified:
11 years, 11 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

googleapi: add types for slices of numbers that marshal to stringified JSON Thanks to Paul Carleton for debugging & initial patch. No API rebuild yet.

Patch Set 2 : diff -r a5bd9c1fdc8c https://code.google.com/p/google-api-go-client/ #

Patch Set 3 : diff -r a5bd9c1fdc8c https://code.google.com/p/google-api-go-client/ #

Patch Set 4 : diff -r a5bd9c1fdc8c https://code.google.com/p/google-api-go-client/ #

Total comments: 1

Patch Set 5 : diff -r a5bd9c1fdc8c https://code.google.com/p/google-api-go-client/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+369 lines, -1 line)			Patch
M	google-api-go-generator/gen.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	google-api-go-generator/gen_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	google-api-go-generator/testdata/quotednum.json	View	1 2	1 chunk	+94 lines, -0 lines	0 comments	Download
A	google-api-go-generator/testdata/quotednum.want	View	1 2	1 chunk	+64 lines, -0 lines	0 comments	Download
A	googleapi/types.go	View	1 2 3 4	1 chunk	+150 lines, -0 lines	0 comments	Download
A	googleapi/types_test.go	View	1 2 3	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/google-api-go-client/

11 years, 11 months ago (2013-10-22 20:41:36 UTC) #1

LGTM but fix comments https://codereview.appspot.com/15900044/diff/90001/googleapi/types.go File googleapi/types.go (right): https://codereview.appspot.com/15900044/diff/90001/googleapi/types.go#newcode12 googleapi/types.go:12: // Int64s is a slice ...

11 years, 11 months ago (2013-10-22 20:49:33 UTC) #2

bradfitz

11 years, 11 months ago (2013-10-22 21:01:33 UTC) #3

*** Submitted as
https://code.google.com/p/google-api-go-client/source/detail?r=5091892573c7 ***

googleapi: add types for slices of numbers that marshal to stringified JSON

Thanks to Paul Carleton for debugging & initial patch.

No API rebuild yet.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/15900044

Expand All Messages | Collapse All Messages