Issue 15870043: code review 15870043: math: amd64p32 assembly routines

Issue 15870043: code review 15870043: math: amd64p32 assembly routines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 5 months ago

Reviewers:
bradfitz

CC:
bradfitz

Visibility:
Public.

Description

math: amd64p32 assembly routines These routines only manipulate float64 values, so the amd64 and amd64p32 can share assembly. The large number of files is symptomatic of a problem with package path: it is a Go package structured like a C library. But that will need to wait for another day. See golang.org/s/go13nacl for design overview. This CL is publicly visible but not CC'ed to golang-dev, to avoid distracting from the preparation of the Go 1.2 release. This CL and the others will be checked into my rsc-go13nacl clone repo for now, and I will send CLs against the main repo early in the Go 1.3 development.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -0 lines)			Patch
A	src/pkg/math/abs_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/asin_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/atan2_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/atan_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/big/arith_amd64p32.s	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
A	src/pkg/math/dim_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/exp2_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/exp_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/expm1_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/floor_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/frexp_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/hypot_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/ldexp_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/log10_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/log1p_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/log_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/mod_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/modf_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/remainder_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/sin_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/sincos_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/sqrt_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/math/tan_amd64p32.s	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz@golang.org, I'd like you to review this change to https://code.google.com/r/rsc-go13nacl

10 years, 5 months ago (2013-11-11 14:51:56 UTC) #2

rsc

10 years, 5 months ago (2013-11-11 14:52:02 UTC) #3

*** Submitted as b011c3dc687e ***

math: amd64p32 assembly routines

These routines only manipulate float64 values,
so the amd64 and amd64p32 can share assembly.

The large number of files is symptomatic of a problem
with package path: it is a Go package structured like a C library.
But that will need to wait for another day.

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R=bradfitz
https://codereview.appspot.com/15870043

Expand All Messages | Collapse All Messages