[dev.power64] code review 158360043: runtime: fix SigaltstackT definition definition for pow...

runtime: fix SigaltstackT definition for power64le

Also updated defs3_linux.go but had to manually edit defs_linux_power64le.h. Will regenerate the file when cgo is working natively on ppc64.

[dave_cheney.net, 2014-10-22 20:57:31]

Hello rsc@golang.org, austin@google.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to the dev.power64 branch of
https://code.google.com/p/go

[austin, 2014-10-22 21:22:29]

LGTM.

I'm working on fixing a bunch of casualties from merging to default, so
dev.power64 is quite broken at the moment.

On Wed, Oct 22, 2014 at 4:57 PM, <dave@cheney.net> wrote:

> Reviewers: rsc, austin,
>
> Message:
> Hello rsc@golang.org, austin@google.com (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to the dev.power64 branch of
> https://code.google.com/p/go
>
>
> Description:
> runtime: fix SigaltstackT definition definition for power64le
>
> Also updated defs3_linux.go but had to manually edit
> defs_linux_power64le.h. Will regenerate the file when cgo is working
> natively on ppc64.
>
> Please review this at https://codereview.appspot.com/158360043/
>
> Affected files (+4, -4 lines):
>   M src/runtime/defs3_linux.go
>   M src/runtime/defs_linux_power64le.h
>
>
> Index: src/runtime/defs3_linux.go
> ===================================================================
> --- a/src/runtime/defs3_linux.go
> +++ b/src/runtime/defs3_linux.go
> @@ -35,7 +35,7 @@
>  type FPregset C.elf_fpregset_t
>  type Vreg C.elf_vrreg_t
>
> -type Sigaltstack C.struct_sigaltstack
> +type SigaltstackT C.struct_sigaltstack
>
>  // PPC64 uses sigcontext in place of mcontext in ucontext.
>  // see http://git.kernel.org/cgit/linux/kernel/git/torvalds/
> linux.git/tree/arch/powerpc/include/uapi/asm/ucontext.h
> Index: src/runtime/defs_linux_power64le.h
> ===================================================================
> --- a/src/runtime/defs_linux_power64le.h
> +++ b/src/runtime/defs_linux_power64le.h
> @@ -147,7 +147,7 @@
>  //typedef struct Usigset Usigset;
>  typedef struct Ptregs Ptregs;
>  typedef struct Vreg Vreg;
> -typedef struct Sigaltstack Sigaltstack;
> +typedef struct SigaltstackT SigaltstackT;
>  typedef struct Sigcontext Sigcontext;
>  typedef struct Ucontext Ucontext;
>
> @@ -179,7 +179,7 @@
>         uint32  u[4];
>  };
>
> -struct Sigaltstack {
> +struct SigaltstackT {
>         byte    *ss_sp;
>         int32   ss_flags;
>         byte    Pad_cgo_0[4];
> @@ -201,7 +201,7 @@
>  struct Ucontext {
>         uint64  uc_flags;
>         Ucontext        *uc_link;
> -       Sigaltstack     uc_stack;
> +       SigaltstackT    uc_stack;
>         Usigset uc_sigmask;
>         Usigset __unused[15];
>         Sigcontext      uc_mcontext;
>
>
>

[dave_cheney.net, 2014-10-22 21:24:56]

That's ok, I don't expect it to build cleanly, but I have access to a
ppc64le machine so can test on that platform.

On Thu, Oct 23, 2014 at 8:22 AM, Austin Clements <austin@google.com> wrote:
> LGTM.
>
> I'm working on fixing a bunch of casualties from merging to default, so
> dev.power64 is quite broken at the moment.
>
> On Wed, Oct 22, 2014 at 4:57 PM, <dave@cheney.net> wrote:
>>
>> Reviewers: rsc, austin,
>>
>> Message:
>> Hello rsc@golang.org, austin@google.com (cc:
>> golang-codereviews@googlegroups.com),
>>
>> I'd like you to review this change to the dev.power64 branch of
>> https://code.google.com/p/go
>>
>>
>> Description:
>> runtime: fix SigaltstackT definition definition for power64le
>>
>> Also updated defs3_linux.go but had to manually edit
>> defs_linux_power64le.h. Will regenerate the file when cgo is working
>> natively on ppc64.
>>
>> Please review this at https://codereview.appspot.com/158360043/
>>
>> Affected files (+4, -4 lines):
>>   M src/runtime/defs3_linux.go
>>   M src/runtime/defs_linux_power64le.h
>>
>>
>> Index: src/runtime/defs3_linux.go
>> ===================================================================
>> --- a/src/runtime/defs3_linux.go
>> +++ b/src/runtime/defs3_linux.go
>> @@ -35,7 +35,7 @@
>>  type FPregset C.elf_fpregset_t
>>  type Vreg C.elf_vrreg_t
>>
>> -type Sigaltstack C.struct_sigaltstack
>> +type SigaltstackT C.struct_sigaltstack
>>
>>  // PPC64 uses sigcontext in place of mcontext in ucontext.
>>  // see
>>
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/powe...
>> Index: src/runtime/defs_linux_power64le.h
>> ===================================================================
>> --- a/src/runtime/defs_linux_power64le.h
>> +++ b/src/runtime/defs_linux_power64le.h
>> @@ -147,7 +147,7 @@
>>  //typedef struct Usigset Usigset;
>>  typedef struct Ptregs Ptregs;
>>  typedef struct Vreg Vreg;
>> -typedef struct Sigaltstack Sigaltstack;
>> +typedef struct SigaltstackT SigaltstackT;
>>  typedef struct Sigcontext Sigcontext;
>>  typedef struct Ucontext Ucontext;
>>
>> @@ -179,7 +179,7 @@
>>         uint32  u[4];
>>  };
>>
>> -struct Sigaltstack {
>> +struct SigaltstackT {
>>         byte    *ss_sp;
>>         int32   ss_flags;
>>         byte    Pad_cgo_0[4];
>> @@ -201,7 +201,7 @@
>>  struct Ucontext {
>>         uint64  uc_flags;
>>         Ucontext        *uc_link;
>> -       Sigaltstack     uc_stack;
>> +       SigaltstackT    uc_stack;
>>         Usigset uc_sigmask;
>>         Usigset __unused[15];
>>         Sigcontext      uc_mcontext;
>>
>>
>

[dave_cheney.net, 2014-10-22 21:58:30]

*** Submitted as https://code.google.com/p/go/source/detail?r=3f05c467402b ***

[dev.power64] runtime: fix SigaltstackT definition for power64le

Also updated defs3_linux.go but had to manually edit defs_linux_power64le.h.
Will regenerate the file when cgo is working natively on ppc64.

LGTM=austin
R=rsc, austin
CC=golang-codereviews
https://codereview.appspot.com/158360043