Issue 158350043: [dev.power64] code review 158350043: runtime: Fix broken merge of noasm.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 158350043: [dev.power64] code review 158350043: runtime: Fix broken merge of noasm.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by austin

Modified:
10 years, 4 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: Fix broken merge of noasm.go The earlier dev.power64 merge missed the port of runtime/noasm.goc to runtime/noasm_arm.go. This CL fixes this by moving noasm_arm.go to noasm.go and adding a +build to share the file between arm and power64.

Patch Set 1 #

Patch Set 2 : diff -r d03ae15f8e35ffc85779e7b53769651055daf22e https://code.google.com/p/go #

Patch Set 3 : diff -r d03ae15f8e35ffc85779e7b53769651055daf22e https://code.google.com/p/go #

Patch Set 4 : diff -r d03ae15f8e35ffc85779e7b53769651055daf22e https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/runtime/noasm.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

austin

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...

10 years, 4 months ago (2014-10-22 18:00:44 UTC) #1

austin

10 years, 4 months ago (2014-10-22 18:02:18 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=36f7fc949548 ***

[dev.power64] runtime: Fix broken merge of noasm.go

The earlier dev.power64 merge missed the port of
runtime/noasm.goc to runtime/noasm_arm.go.  This CL fixes this
by moving noasm_arm.go to noasm.go and adding a +build to
share the file between arm and power64.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/158350043

Expand All Messages | Collapse All Messages