Issue 158250043: code review 158250043: fix clang 3.4 warnings and ignore uninteresting ones

Issue 158250043: code review 158250043: fix clang 3.4 warnings and ignore uninteresting ones (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by 0intro

Modified:
10 years, 1 month ago

Reviewers:
rsc

CC:
rsc

Visibility:
Public.

Description

fix clang 3.4 warnings and ignore uninteresting ones fixed warnings: src/cmd/fossil/disk.c:37:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:38:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:39:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:40:13: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:41:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/libndb/ndbreorder.c:41:55: warning: for loop has empty body [-Wempty-body] ignored warnings: src/cmd/acid/dbg.y:393:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/lex/parser.y:886:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/rc/syn.y:303:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/units.y:1003:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/libregexp/regcomp.c:19:16: warning: variable 'reprog' is not needed and will not be emitted [-Wunneeded-internal-declaration]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
M	bin/9c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/fossil/disk.c	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/libndb/ndbreorder.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

0intro

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port

10 years, 1 month ago (2014-10-21 09:23:40 UTC) #1

0intro

10 years, 1 month ago (2014-10-21 12:22:36 UTC) #3

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=a97a47f7b91e ***

fix clang 3.4 warnings and ignore uninteresting ones

fixed warnings:
src/cmd/fossil/disk.c:37:14: warning: use of GNU 'missing =' extension in
designator [-Wgnu-designator]
src/cmd/fossil/disk.c:38:14: warning: use of GNU 'missing =' extension in
designator [-Wgnu-designator]
src/cmd/fossil/disk.c:39:14: warning: use of GNU 'missing =' extension in
designator [-Wgnu-designator]
src/cmd/fossil/disk.c:40:13: warning: use of GNU 'missing =' extension in
designator [-Wgnu-designator]
src/cmd/fossil/disk.c:41:14: warning: use of GNU 'missing =' extension in
designator [-Wgnu-designator]
src/libndb/ndbreorder.c:41:55: warning: for loop has empty body [-Wempty-body]

ignored warnings:
src/cmd/acid/dbg.y:393:9: warning: array index -1 is before the beginning of the
array [-Warray-bounds]
src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the
array [-Warray-bounds]
src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the
array [-Warray-bounds]
src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of
the array [-Warray-bounds]
src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of
the array [-Warray-bounds]
src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the
array [-Warray-bounds]
src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the
array [-Warray-bounds]
src/cmd/lex/parser.y:886:9: warning: array index -1 is before the beginning of
the array [-Warray-bounds]
src/cmd/rc/syn.y:303:9: warning: array index -1 is before the beginning of the
array [-Warray-bounds]
src/cmd/units.y:1003:9: warning: array index -1 is before the beginning of the
array [-Warray-bounds]
src/libregexp/regcomp.c:19:16: warning: variable 'reprog' is not needed and will
not be emitted [-Wunneeded-internal-declaration]

LGTM=rsc
R=rsc
https://codereview.appspot.com/158250043

Expand All Messages | Collapse All Messages