Issue 158240043: code review 158240043: col: import from plan 9, by popular demand

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 158240043: code review 158240043: col: import from plan 9, by popular demand (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

col: import from plan 9, by popular demand

Patch Set 1 #

Patch Set 2 : diff -r 569143f2aa4e377c403f16937e677bc1e6d689f8 https://code.google.com/p/plan9port #

Patch Set 3 : diff -r eb72acb66bbd773e5772ee050107abc9702c06ba https://code.google.com/p/plan9port #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+352 lines, -0 lines)			Patch
	A	man/man1/col.1	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download
	A	src/cmd/col.c	View	1	1 chunk	+295 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port

9 years, 6 months ago (2014-10-21 00:41:38 UTC) #1

rsc

9 years, 6 months ago (2014-10-21 00:41:47 UTC) #2

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=557757d973d0 ***

col: import from plan 9, by popular demand

TBR=rsc
https://codereview.appspot.com/158240043

Expand All Messages | Collapse All Messages