Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(512)

Issue 158090043: code review 158090043: go.crypto/ssh/terminal: fix crash when terminal narrowe... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by agl1
Modified:
9 years, 6 months ago
Reviewers:
bradfitz
CC:
bradfitz, golang-codereviews
Visibility:
Public.

Description

go.crypto/ssh/terminal: fix crash when terminal narrower than prompt. Previously, if the current line was "empty", resizes wouldn't trigger repaints. However, the line can be empty when the prompt is non-empty and the code would then panic after a resize because the cursor position was outside of the terminal.

Patch Set 1 #

Patch Set 2 : diff -r 2a61df2221b6be21be1c1ded77821b0f71b29584 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r d415780565165acd4cc9d476e485d4603b7c42ec https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ssh/terminal/terminal.go View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4
agl1
9 years, 7 months ago (2014-10-18 21:13:12 UTC) #1
bradfitz
LGTM On Sat, Oct 18, 2014 at 11:13 PM, <agl@golang.org> wrote: > Reviewers: bradfitz, > ...
9 years, 7 months ago (2014-10-19 13:39:58 UTC) #2
agl1
Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
9 years, 6 months ago (2014-10-25 18:16:05 UTC) #3
agl1
9 years, 6 months ago (2014-10-25 18:16:27 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=43bd7e5d279a&repo=crypto ***

go.crypto/ssh/terminal: fix crash when terminal narrower than prompt.

Previously, if the current line was "empty", resizes wouldn't trigger
repaints. However, the line can be empty when the prompt is non-empty
and the code would then panic after a resize because the cursor position
was outside of the terminal.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/158090043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b