Issue 158010043: Add 'start' parameter to API search.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 158010043: Add 'start' parameter to API search.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by bac

Modified:
9 years, 6 months ago

Reviewers:
j.c.sackett, mp+238457

Visibility:
Public.

Description

Add 'start' parameter to API search. The start is the zero-based index into the search results. It can be used in conjunction with limit. https://code.launchpad.net/~bac/charmworld/bug-1379397/+merge/238457 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add 'start' parameter to API search. #

Patch Set 3 : Add 'start' parameter to API search. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/search.py	View	4 chunks	+16 lines, -1 line	0 comments	Download
M	charmworld/tests/test_search.py	View	2 chunks	+42 lines, -0 lines	0 comments	Download
M	charmworld/views/api/__init__.py	View	5 chunks	+24 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

j.c.sackett

Brad-- Thanks, just one minor note. https://codereview.appspot.com/158010043/diff/1/charmworld/search.py File charmworld/search.py (right): https://codereview.appspot.com/158010043/diff/1/charmworld/search.py#newcode701 charmworld/search.py:701: hits = hits[start:] ...

9 years, 6 months ago (2014-10-15 16:39:16 UTC) #2

bac

Thanks for the review JC. The code works as is but I'll move it up ...

9 years, 6 months ago (2014-10-15 16:43:57 UTC) #3

bac

. https://codereview.appspot.com/158010043/diff/1/charmworld/search.py File charmworld/search.py (right): https://codereview.appspot.com/158010043/diff/1/charmworld/search.py#newcode701 charmworld/search.py:701: hits = hits[start:] The way it is is ...

9 years, 6 months ago (2014-10-15 16:44:10 UTC) #4

bac

9 years, 6 months ago (2014-10-15 18:17:55 UTC) #5

Jon I assume you intended to mark the review as LGTM but forgot.

So I'm doing it myself so I can land. Apologies if that wasn't your intent.

--bac

Expand All Messages | Collapse All Messages