Issue 15800043: code review 15800043: runtime: assembly and system calls for Native Client x86-32

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15800043: code review 15800043: runtime: assembly and system calls for Native Client x86-32 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 5 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

runtime: assembly and system calls for Native Client x86-32 See golang.org/s/go13nacl for design overview. This CL is publicly visible but not CC'ed to golang-dev, to avoid distracting from the preparation of the Go 1.2 release. This CL and the others will be checked into my rsc-go13nacl clone repo for now, and I will send CLs against the main repo early in the Go 1.3 development.

Patch Set 1 #

Patch Set 2 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 3 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 4 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 5 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 6 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 7 : diff -r eca0ca43a863 https://code.google.com/r/rsc-go13nacl #

Patch Set 8 : diff -r de159d1f10be https://code.google.com/r/rsc-go13nacl #

Patch Set 9 : diff -r 43234f082eec https://code.google.com/r/rsc-go13nacl #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+320 lines, -2 lines)			Patch
M	src/pkg/runtime/asm_386.s	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
A	src/pkg/runtime/defs_nacl_386.h	View	1 2 3 4	1 chunk	+63 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/rt0_nacl_386.s	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/sys_nacl_386.s	View	1	1 chunk	+232 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc, I'd like you to review this change to https://code.google.com/r/rsc-go13nacl

10 years, 5 months ago (2013-11-11 15:03:32 UTC) #1

rsc

10 years, 5 months ago (2013-11-11 15:03:39 UTC) #2

*** Submitted as 9c8d1d890aaa ***

runtime: assembly and system calls for Native Client x86-32

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R=rsc
https://codereview.appspot.com/15800043

Expand All Messages | Collapse All Messages