Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(960)

Issue 157820043: code review 157820043: net: skip new TestReadFromUDP on nacl and plan9 (fixes ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by brainman
Modified:
7 years, 1 month ago
Reviewers:
gobot, bradfitz
CC:
0intro, golang-codereviews
Visibility:
Public.

Description

net: skip new TestReadFromUDP on nacl and plan9 (fixes build)

Patch Set 1 #

Patch Set 2 : diff -r c7511b8a22c4382e12b01f96b9209c69282064be https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c7511b8a22c4382e12b01f96b9209c69282064be https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c7511b8a22c4382e12b01f96b9209c69282064be https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/net/udp_test.go View 1 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 7
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 1 month ago (2014-10-09 22:38:23 UTC) #1
brainman
Created an issue for it https://code.google.com/p/go/issues/detail?id=8916 Alex
7 years, 1 month ago (2014-10-09 22:45:22 UTC) #2
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=84d418aa033b *** net: skip new TestReadFromUDP on nacl and plan9 (fixes build) ...
7 years, 1 month ago (2014-10-09 22:46:49 UTC) #3
gobot
This CL appears to have broken the netbsd-amd64-bsiegert builder. See http://build.golang.org/log/2d73270c57249bad8493f117b5e420f870d6a859
7 years, 1 month ago (2014-10-09 23:06:33 UTC) #4
brainman
On 2014/10/09 23:06:33, gobot wrote: > This CL appears to have broken the netbsd-amd64-bsiegert builder. ...
7 years, 1 month ago (2014-10-09 23:08:57 UTC) #5
bradfitz
https://codereview.appspot.com/157820043/diff/60001/src/net/udp_test.go File src/net/udp_test.go (right): https://codereview.appspot.com/157820043/diff/60001/src/net/udp_test.go#newcode41 src/net/udp_test.go:41: t.Skipf("skipping test on %q", runtime.GOOS) this skip message should ...
7 years, 1 month ago (2014-10-10 01:42:09 UTC) #6
brainman
7 years, 1 month ago (2014-10-10 02:00:50 UTC) #7
Message was sent while issue was closed.
On 2014/10/10 01:42:09, bradfitz wrote:
> this skip message should reference the issue number. Please fix, since you
TBR'd
> the submit.

Here is the CL 154220043.

Alex
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b