Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1420)

Issue 1578041: code review 1578041: add Windows ForkExec, Syscall12 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by kardia
Modified:
12 years ago
Reviewers:
CC:
brainman, rsc, golang-dev
Visibility:
Public.

Description

add Windows ForkExec, Syscall12 Updated script that generates syscalls to use them if need be. Added windows ForkExec to windows. Needs tracing, env, and Fd added still. Renamed syscall/exec.go to exec_unix.go.

Patch Set 1 #

Patch Set 2 : code review 1578041: Added Syscall12 and Syscall15 to allow more Win... #

Total comments: 4

Patch Set 3 : code review 1578041: add Windows ForkExec, Syscall12, Syscall15 #

Patch Set 4 : code review 1578041: add Windows ForkExec, Syscall12, Syscall15 #

Total comments: 8

Patch Set 5 : code review 1578041: add Windows ForkExec, Syscall12 #

Total comments: 8

Patch Set 6 : code review 1578041: add Windows ForkExec, Syscall12 #

Total comments: 1

Patch Set 7 : code review 1578041: add Windows ForkExec, Syscall12 #

Patch Set 8 : code review 1578041: add Windows ForkExec, Syscall12 #

Patch Set 9 : code review 1578041: add Windows ForkExec, Syscall12 #

Patch Set 10 : code review 1578041: add Windows ForkExec, Syscall12 #

Patch Set 11 : code review 1578041: add Windows ForkExec, Syscall12 #

Patch Set 12 : code review 1578041: add Windows ForkExec, Syscall12 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -4 lines) Patch
M src/pkg/runtime/windows/os.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/windows/syscall.goc View 1 2 3 4 5 6 7 9 10 11 1 chunk +23 lines, -0 lines 0 comments Download
M src/pkg/runtime/windows/thread.c View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/Makefile View 1 2 3 4 5 6 7 2 chunks +7 lines, -1 line 0 comments Download
M src/pkg/syscall/exec_unix.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/pkg/syscall/exec_windows.go View 1 2 3 4 5 6 7 9 10 11 1 chunk +199 lines, -0 lines 0 comments Download
M src/pkg/syscall/mksyscall_windows.sh View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 4 5 6 7 9 10 2 chunks +6 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 3 4 5 6 7 9 10 3 chunks +73 lines, -1 line 0 comments Download
M src/pkg/syscall/ztypes_windows_386.go View 1 2 3 4 5 6 7 9 10 4 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 33
kardia
Hello brainman, rsc1 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 11 months ago (2010-06-07 03:56:05 UTC) #1
rsc1
13 years, 11 months ago (2010-06-07 19:38:28 UTC) #2
rsc1
thanks for doing this. please make the first line of the CL description follow the ...
13 years, 11 months ago (2010-06-07 20:01:07 UTC) #3
brainman
On 2010/06/07 03:56:05, kardia wrote: > Hello brainman, rsc1 (cc: mailto:golang-dev@googlegroups.com), > > I'd like ...
13 years, 11 months ago (2010-06-08 07:18:24 UTC) #4
kardia
> cmd, err := exec.Run("c:\\winnt\\system32\\netstat.exe", > []string{"netstat"}, nil, "", > exec.DevNull, exec.Pipe, exec.DevNull) Right now ...
13 years, 11 months ago (2010-06-08 13:43:38 UTC) #5
kardia
Hello brainman, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2010-06-08 14:09:21 UTC) #6
kardia
On 2010/06/08 14:09:21, kardia wrote: > Hello brainman, rsc (cc: mailto:golang-dev@googlegroups.com), > > Please take ...
13 years, 11 months ago (2010-06-08 14:17:04 UTC) #7
kardia
Hello brainman, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2010-06-08 14:25:27 UTC) #8
brainman
http://codereview.appspot.com/1578041/diff/14001/11009 File src/pkg/runtime/windows/syscall.goc (right): http://codereview.appspot.com/1578041/diff/14001/11009#newcode49 src/pkg/runtime/windows/syscall.goc:49: func Syscall15(trap uintptr, a1 uintptr, a2 uintptr, a3 uintptr, ...
13 years, 11 months ago (2010-06-09 09:18:34 UTC) #9
kardia
> http://codereview.appspot.com/1578041/diff/14001/11009#newcode49 > src/pkg/runtime/windows/syscall.goc:49: func Syscall15(trap uintptr, a1 uintptr, > a2 uintptr, a3 uintptr, a4 ...
13 years, 11 months ago (2010-06-11 01:32:15 UTC) #10
kardia
Hello brainman, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2010-06-11 01:33:20 UTC) #11
brainman
http://codereview.appspot.com/1578041/diff/11018/26004 File src/pkg/syscall/exec_windows.go (right): http://codereview.appspot.com/1578041/diff/11018/26004#newcode109 src/pkg/syscall/exec_windows.go:109: // 0x00000400 = UNICODE env Do not need the ...
13 years, 11 months ago (2010-06-11 11:16:37 UTC) #12
kardia
Made changes and modified for recent syscall change. Tested, appears to function. Thank you for ...
13 years, 11 months ago (2010-06-14 01:34:46 UTC) #13
kardia
Hello brainman, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2010-06-14 01:35:21 UTC) #14
brainman
http://codereview.appspot.com/1578041/diff/34001/35008 File src/pkg/syscall/syscall_windows.go (right): http://codereview.appspot.com/1578041/diff/34001/35008#newcode132 src/pkg/syscall/syscall_windows.go:132: //sys CreateProcess(appName *int16, commandLine *uint16, procSecurity *int16, threadSecurity *int16, ...
13 years, 11 months ago (2010-06-15 01:35:09 UTC) #15
kardia
Hello brainman, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2010-06-15 01:54:33 UTC) #16
brainman
LGTM
13 years, 11 months ago (2010-06-15 01:56:40 UTC) #17
kardia
Hello brainman, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2010-06-30 20:55:58 UTC) #18
kardia
Hello brainman, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2010-06-30 21:02:34 UTC) #19
kardia
On 2010/06/30 21:02:34, kardia wrote: > Hello brainman, rsc (cc: mailto:golang-dev@googlegroups.com), > > Please take ...
13 years, 10 months ago (2010-06-30 21:03:30 UTC) #20
alex.brainman_eventree.com
Daniel, > Updated patch set to merge with tip. > It's out of date again. ...
13 years, 10 months ago (2010-07-12 23:42:37 UTC) #21
kardia
Merged again. Thanks, -Daniel
13 years, 10 months ago (2010-07-13 00:38:08 UTC) #22
brainman
On 2010/06/07 20:01:07, rsc1 wrote: > ... Ping.
13 years, 10 months ago (2010-07-13 02:41:43 UTC) #23
kardia
I know people are busy but is there interest or comments to this? Thanks, -Daniel ...
13 years, 10 months ago (2010-07-19 14:32:24 UTC) #24
brainman
On 2010/07/19 14:32:24, kardia wrote: > I know people are busy but is there interest ...
13 years, 10 months ago (2010-07-19 23:43:05 UTC) #25
rsc
Thanks very much for working on this. This looks good to me but I'd like ...
13 years, 10 months ago (2010-07-20 06:09:29 UTC) #26
kardia
Russ, I wans't sure about the exact desired behavior of ForkExec. I'v e made the ...
13 years, 10 months ago (2010-07-22 00:21:50 UTC) #27
iant2
kardianos@gmail.com writes: > Russ, I wans't sure about the exact desired behavior of ForkExec. I'v ...
13 years, 10 months ago (2010-07-22 08:59:07 UTC) #28
kardia
Please take another look. Thanks, -Daniel
13 years, 10 months ago (2010-07-22 15:33:48 UTC) #29
brainman
I don't know much about this process. I think the only way we'll find out ...
13 years, 10 months ago (2010-07-23 06:48:14 UTC) #30
rsc
LGTM leaving for alex
13 years, 10 months ago (2010-07-23 06:56:26 UTC) #31
kardia
On a side note, I have tested the functionality and the fds and envv vars ...
13 years, 10 months ago (2010-07-23 14:23:26 UTC) #32
brainman
13 years, 10 months ago (2010-07-25 23:43:44 UTC) #33
*** Submitted as http://code.google.com/p/go/source/detail?r=e0df83335988 ***

syscall: add ForkExec, Syscall12 on Windows

R=brainman, rsc
CC=golang-dev
http://codereview.appspot.com/1578041

Committer: Alex Brainman <alex.brainman@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b