Issue 1577041: Get stops in bounds from database

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1577041: Get stops in bounds from database

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by calidion

Modified:
7 years, 4 months ago

Reviewers:
xan, weiliu, baiming, leio.chen, lychen

CC:
xinxing_google.com, lishuangfeng_gmail.com

Base URL:
http://scheduleeditor.googlecode.com/svn/trunk/v2/

Visibility:
Public.

Patch Set 2 : fixed bug #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -14 lines)			Patch
	M	schedule_editor.py	View		2 chunks	+1 line, -14 lines	0 comments	Download
	M	transitfeed_editor.py	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

weiliu

http://codereview.appspot.com/1577041/diff/1/3 File schedule_editor.py (right): http://codereview.appspot.com/1577041/diff/1/3#newcode332 schedule_editor.py:332: return EditableStop.GetStopsInBoundingBox(schedule._db, n, e, s, w, limit) Where is ...

13 years, 10 months ago (2010-06-07 09:36:25 UTC) #2

calidion

updated http://codereview.appspot.com/1577041/diff/1/3 File schedule_editor.py (right): http://codereview.appspot.com/1577041/diff/1/3#newcode332 schedule_editor.py:332: return EditableStop.GetStopsInBoundingBox(schedule._db, n, e, s, w, limit) On ...

13 years, 10 months ago (2010-06-07 13:39:24 UTC) #3

calidion

13 years, 10 months ago (2010-06-07 13:43:05 UTC) #5

updated to rev 88.

2010/6/7 <weiliu@google.com>

> LGTM
>
>
> http://codereview.appspot.com/1577041/show
>

Expand All Messages | Collapse All Messages